fix: Fixed ConcurrentModificationException in cancelAll()#260
Open
greenbear26 wants to merge 2 commits intoFTCLib:devfrom
Open
fix: Fixed ConcurrentModificationException in cancelAll()#260greenbear26 wants to merge 2 commits intoFTCLib:devfrom
greenbear26 wants to merge 2 commits intoFTCLib:devfrom
Conversation
Merge dev into master
|
Yo someone should merge this PR in I need my |
|
FTCLib is not maintained anymore. Use SolversLib instead, a maintained fork of FTCLib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Requests
Please note that we accept pull requests from anyone, but that does not mean it will be merged.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
Please make sure your PR satisfies the requirements of the contributing page
This PR is just fixing an issue when calling cancelAll() in the CommandScheduler. It was previously causing a ConcurrentModificationException when removing commands from m_scheduledCommands while looping through it. This new code fixes that.
On another note, the gradle version for this project is very outdated, and it should be under consideration to update it.