fix: Double ending issue in ParallelRaceGroup#261
Open
Nv7-GitHub wants to merge 2 commits intoFTCLib:masterfrom
Open
fix: Double ending issue in ParallelRaceGroup#261Nv7-GitHub wants to merge 2 commits intoFTCLib:masterfrom
Nv7-GitHub wants to merge 2 commits intoFTCLib:masterfrom
Conversation
Author
|
I also fixed the issue in |
Contributor
|
@Nv7-GitHub This was so needed, I spotted this issue 2 seasons ago, wrote my own fix for it but forgot to actually write it for the repo in general, good thinking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
ParallelRaceGroupthat ends one of the commands twice. Theendmethod inSequentialCommandGroupupdates its array index to-1when called, so if theendmethod inSequentialCommandGroupis called twice, an array out of bounds error occurs. With the current code, if aSequentialCommandGroupfinishes first in aParallelRaceGroup, a fatal error occurs, so this PR fixes it (without any breaking changes).