Conversation
Co-Authored-By: JFaber151 <[email protected]>
Implement rudimentary duplication, fix NUnit "in use" bug
…ased on thread demand Co-Authored-By: JFaber151 <[email protected]>
Remove initial duplication pool, implement test project duplication b…
Merging, as there are no conflicts
Refactored TypeCollection
Co-Authored-By: JFaber151 <[email protected]>
Clean 05 miguel refactor2
…xcessive test duplication before coverage analysis. Co-Authored-By: JFaber151 <[email protected]>
…on interface redefined
Clean 05 miguel refactor3
…e package issues.
…ify into 05-clean-miguelRefactor4
Ammending some build errors
TimonPost
left a comment
There was a problem hiding this comment.
Thanks for the PR. I see various good improvements. Also, I see various things that are changed with a future note that it is going to be fixed. When we merge this PR we will likely break the dotnet/xunit support? I do not mind this to be broken for a bit in master while I do worry wether it will be fixed before the end of the project. What are the ideas from your side on this? I am happy to merge this if the comments are resolved, various good improvements have been done which is nice.
| ITestHostRunFactory testHost = settings.TestHost switch | ||
| { | ||
| _ => new DotnetTestHostRunnerFactory() // TODO: Use Faultify.TestRunner.XUnit/NUnit for in memory testing. | ||
| _ => new NUnitTestHostRunnerFactory() // TODO: Use Faultify.TestRunner.XUnit/NUnit for in memory testing. |
There was a problem hiding this comment.
I understand NUnit is the focus for now. Let's keep in mind this is enabled currently, only when XUNIT is working we can do a release. Ideally, we want dotnet test to remain working. Does it work currently? Perhaps we can put it as default sucht that faultify works for everyone using the master branch version of faultify.
| "commandName": "Project", | ||
| "commandLineArgs": "-t E:\\programming\\stryker-net\\src\\Stryker.Core\\Stryker.Core.UnitTest\\Stryker.Core.UnitTest.csproj -p 9" | ||
| "commandName": "Project", | ||
| "commandLineArgs": "-t C:\\Users\\Vxvl4\\source\\repos\\Faultify\\Benchmark\\Faultify.Benchmark.NUnit\\Faultify.Benchmark.NUnit.csproj -f pdf" |
There was a problem hiding this comment.
Perhaps we need to figure a way out to have a relative path here instead of an absolute path. Not mandoatory
|
|
||
| _fileStream = new FileStream(FullFilePath(), FileMode.Open, FileAccess.Read, FileShare.ReadWrite); | ||
| } | ||
|
|
| } | ||
|
|
||
| testProject.FreeTestProject(); | ||
| testProject.FreeTestProject(); //TODO: replace with deletion |
There was a problem hiding this comment.
I see a todo while I also see this function. Can this function be used?
| } | ||
| catch (Exception e) | ||
| { | ||
| Console.WriteLine(e.Message); |
There was a problem hiding this comment.
Ideally, we want to use the logger instead. Would this be possible?
|
|
||
| public List<TestProjectDuplication> MakeInitialCopies(IProjectInfo testProject, int count) | ||
| /// <summary> | ||
| /// Create the very first duplication of the project that will be used for coverage calculations |
There was a problem hiding this comment.
|
|
||
|
|
||
| /// <summary> | ||
| /// Delete the test project completely |
There was a problem hiding this comment.
| /// Delete the test project completely | |
| /// Deletes the test project completely. |
| } | ||
|
|
||
| /// <summary> | ||
| /// Create a copy based on the initial duplication's data |
There was a problem hiding this comment.
| /// Create a copy based on the initial duplication's data | |
| /// Creates a copy based on the initial duplication's data |
Working line numbers
There was a problem hiding this comment.
- Why did you switch from build in dotnet core log to NLog ? If for static reference reasons we can easily introduce a wrapper such as:
internal static class ApplicationLogging
{
internal static ILoggerFactory LoggerFactory { get; set; }// = new LoggerFactory();
internal static ILogger CreateLogger<T>() => LoggerFactory.CreateLogger<T>();
internal static ILogger CreateLogger(string categoryName) => LoggerFactory.CreateLogger(categoryName);
}
to facilitate the static reference part. The static part is I think an improvement from the current implementation. Staying with build in Microsoft libraries has my preference.
- I see the open PR is growing in size 2K lines of changes. This one becomes un reviewable. Is there something we can do to split it up in smaller chunks or is it to late for that? 200 lines is recommended on average
| } | ||
| catch (Exception e) | ||
| { | ||
| _logger.Fatal(e, "Fatal exception reading file"); |
There was a problem hiding this comment.
| _logger.Fatal(e, "Fatal exception reading file"); | |
| _logger.Fatal(e, "Fatal exception reading mutation coverage file."); |
Co-Authored-By: JFaber151 <[email protected]>
Feat 06 debug data
[skip ci]
Package cleanup
Bug 06 timeout json report
Cln 07 code cleanup and reformat
No description provided.