Open
Conversation
anjali-deshpande-hub
suggested changes
Oct 11, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Review comments:
- Instead of using an absolute path like /Users/fanglingong/newproject/data/raw, it is better to use relative path such as ./data/raw to make the script portable across different machines and environments. Remember that hard coded paths can only work on your machine, while relative paths will adapt to the current directory structure.
(Questions 2, 5, 6) - Minor observation: In Question 8, the command
touch inventory.txtis not required since the redirection operation > will create the file.
Please make the required changes for re-review. Thank you.
|
The automation hasn't ran on this PR, can you please make sure github actions are on for this repo? |
Owner
Author
Hi, “Allow all actions and reusable workflows" is always on. Could you please let me know what else I can do to check or change?
|
danielrazavi
suggested changes
Oct 13, 2025
danielrazavi
left a comment
There was a problem hiding this comment.
Manually marked. Tiny change needed.
| cp server*.log ./data/processed/server_logs | ||
| # 6. Repeat the above step for user logs and event logs | ||
|
|
||
| cp server*.log ./data/processed/user_logs |
There was a problem hiding this comment.
repeat the above steps for user logs and event logs, meaning move the user logs into the user logs folder and move the event logs into the event logs folder.
|
also, part 2 seems to be missing. |
|
Great! Looks good to me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist
1st try