completions: Move to framework_tool/ to include in crates.io release#297
Merged
JohnAZoidberg merged 1 commit intoFrameworkComputer:mainfrom Mar 22, 2026
Merged
Conversation
Update asset paths in Cargo.toml metadata (deb and rpm), the CI completions check, and the README regeneration instructions accordingly
JohnAZoidberg
approved these changes
Mar 22, 2026
Member
JohnAZoidberg
left a comment
There was a problem hiding this comment.
Yeah that makes sense, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm packaging the
framework_toolcrate for Debian and would like to install shell completions as part of the package. I'm using the orig tarball from crates.io as the packaging source (as is standard practice for the Debian Rust team), which only includes the contents of theframework_tool/directory. Thecompletions/directory was previously at the workspace root, so it wasn't published to crates.io and wasn't available to downstream packagersThis PR moves
completions/intoframework_tool/to fix that, and updates asset paths inCargo.tomlmetadata (deb and rpm), the CI completions check, and the README regeneration instructions