Merged
Conversation
libnftnl and mnl is kinda overkill for this, so we're falling back to just wrapping nft directly. netaavark also does this so it makes sense for us too
We don't need to install clang because it's already in the CI image
| - name: Run tests | ||
| run: cargo test --verbose | ||
| - uses: actions/checkout@v4 | ||
| - uses: rui314/setup-mold@v1 |
| - uses: actions/checkout@v4 | ||
| - uses: rui314/setup-mold@v1 | ||
| - name: Run sccache-cache | ||
| uses: mozilla-actions/[email protected] |
TheHeroBrine422
approved these changes
Apr 17, 2026
Contributor
TheHeroBrine422
left a comment
There was a problem hiding this comment.
Generally looks good enough to me. I am a bit concerned about code quality but given odorobo is so new, we will likely end up making a lot of changes before prod release anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a
NetworkAgentActorthat deals with L3 routing for individual VMs, called upon by a stateless hook that reads theVmInfoand does the L3 routing for them.Consider adding Open vSwitch integration or something on here too if we're into that kind of thing, but yea. I am trying to be vendor-agnostic for this so we will be rawdogging netlink and maybe iptables OR nftables.
closes #17