Conversation
ArturNurtdinov
left a comment
There was a problem hiding this comment.
Хорошая работа, код приятно читать
| } | ||
|
|
||
| double totalBill = calculateTotalBill(); | ||
| double sharePerPerson = totalBill / numberOfPeople; |
There was a problem hiding this comment.
Лучше проверить numberOfPeople на 0 перед делением, это сделает класс более безопасным и надёжным
Comment on lines
+43
to
+44
| if (numberOfPeople <= 0) { | ||
| System.out.println("Ошибка: Некорректное значение. Введите число больше 0."); |
There was a problem hiding this comment.
Смысла считать чек на 1 человека нет
Предыдущее условие было правильным
Comment on lines
+111
to
+117
| return rubles + " рублей " + kopecks + " копеек"; | ||
| } else { | ||
| return switch (rublesLastDigit) { | ||
| case 1 -> rubles + " рубль " + kopecks + " копеек"; | ||
| case 2, 3, 4 -> rubles + " рубля " + kopecks + " копеек"; | ||
| default -> rubles + " рублей " + kopecks + " копеек"; | ||
| }; |
There was a problem hiding this comment.
Требования выводить слово "копеек" нет, но если выводишь - то нужно склонять тоже
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
в этом коде используются два класса: Main для управления приложением и BillCalculator для хранения и обработки данных о товарах и расчетов. Приложение запрашивает данные у пользователя, обрабатывает некорректные данные и выводит результаты.