Add NuGet package metadata to Drivelution and Extension components#153
Add NuGet package metadata to Drivelution and Extension components#153
Conversation
|
@copilot You need to add the following content to the project file to give the NuGet package an icon. <ItemGroup>
<None Include="../../../imgs/GeneralUpdate.ico">
<Pack>True</Pack>
<Link>%(Filename)%(Extension)</Link>
<PackagePath>./</PackagePath>
</None>
<None Include="../../../imgs/GeneralUpdate.png">
<Pack>True</Pack>
<Link>%(Filename)%(Extension)</Link>
<PackagePath>./</PackagePath>
</None>
</ItemGroup> |
…eralUpdate.Extension Co-authored-by: JusterZhu <[email protected]>
|
@copilot 9.5.10The version number needs to be modified to 10.2.1. |
Co-authored-by: JusterZhu <[email protected]>
... Added ApplicationIcon property and included both GeneralUpdate.ico and GeneralUpdate.png files in both projects, matching the pattern used in GeneralUpdate.Core and GeneralUpdate.ClientCore. Changes verified in commit e96746f. |
Co-authored-by: JusterZhu <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adds NuGet packaging metadata (versioning, authorship, URLs, tags, icons) for the GeneralUpdate.Drivelution and GeneralUpdate.Extension components so they can be built and packed as first-class NuGet packages consistent with the rest of the repository.
Changes:
- Added NuGet package metadata (Version 10.2.1, tags, release notes, repository metadata, icon settings) to
GeneralUpdate.Drivelution.csprojandGeneralUpdate.Extension.csproj. - Added
ApplicationIcon/PackageIconconfiguration and included icon assets for both projects. - Ensured package icon files are included in the produced
.nupkgviaPack=Trueitems.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/c#/GeneralUpdate.Extension/GeneralUpdate.Extension.csproj |
Adds NuGet metadata + icon packing items for the Extension package. |
src/c#/GeneralUpdate.Drivelution/GeneralUpdate.Drivelution.csproj |
Adds NuGet metadata + icon packing items for the Drivelution package. |
src/c#/GeneralUpdate.Extension/GeneralUpdate.ico |
Adds project icon asset for Extension. |
src/c#/GeneralUpdate.Drivelution/GeneralUpdate.ico |
Adds project icon asset for Drivelution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Description>A VS Code-inspired extension system for .NET applications with comprehensive extension management, update, download, installation, rollback, and compatibility checking capabilities. Supports multi-platform extension deployment with dependency resolution.</Description> | ||
| <Copyright>Copyright © 2020-2026 JusterZhu. All rights reserved.</Copyright> | ||
| <PackageProjectUrl>https://github.com/GeneralLibrary/GeneralUpdate</PackageProjectUrl> | ||
| <PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl> |
There was a problem hiding this comment.
PackageLicenseUrl has been deprecated by NuGet for a while and typically produces pack warnings. Consider switching to PackageLicenseExpression (e.g., Apache-2.0) and/or PackageLicenseFile (packing the repo LICENSE) so the package has modern license metadata.
| <PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl> | |
| <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression> |
| <ApplicationIcon>GeneralUpdate.ico</ApplicationIcon> | ||
| <PackageIcon>GeneralUpdate.png</PackageIcon> | ||
| <RepositoryUrl>https://github.com/GeneralLibrary/GeneralUpdate</RepositoryUrl> | ||
| <RepositoryType>public</RepositoryType> |
There was a problem hiding this comment.
RepositoryType is expected to be the VCS type (commonly git). Using public is non-standard NuGet metadata and may be ignored by clients; consider changing it to git to ensure correct repository metadata in the nupkg.
| <RepositoryType>public</RepositoryType> | |
| <RepositoryType>git</RepositoryType> |
| <Description>A cross-platform driver update management system with support for Windows, Linux, and macOS. Provides driver backup, validation, version comparison, and automatic rollback capabilities.</Description> | ||
| <Copyright>Copyright © 2020-2026 JusterZhu. All rights reserved.</Copyright> | ||
| <PackageProjectUrl>https://github.com/GeneralLibrary/GeneralUpdate</PackageProjectUrl> | ||
| <PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl> |
There was a problem hiding this comment.
PackageLicenseUrl has been deprecated by NuGet for a while and typically produces pack warnings. Consider switching to PackageLicenseExpression (e.g., Apache-2.0) and/or PackageLicenseFile (packing the repo LICENSE) so the package has modern license metadata.
| <PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl> | |
| <PackageLicenseExpression>Apache-2.0</PackageLicenseExpression> |
| <ApplicationIcon>GeneralUpdate.ico</ApplicationIcon> | ||
| <PackageIcon>GeneralUpdate.png</PackageIcon> | ||
| <RepositoryUrl>https://github.com/GeneralLibrary/GeneralUpdate</RepositoryUrl> | ||
| <RepositoryType>public</RepositoryType> |
There was a problem hiding this comment.
RepositoryType is expected to be the VCS type (commonly git). Using public is non-standard NuGet metadata and may be ignored by clients; consider changing it to git to ensure correct repository metadata in the nupkg.
| <RepositoryType>public</RepositoryType> | |
| <RepositoryType>git</RepositoryType> |
NuGet Metadata Authoring for GeneralUpdate.Drivelution and GeneralUpdate.Extension
Summary
Successfully added complete NuGet package metadata to both GeneralUpdate.Drivelution and GeneralUpdate.Extension components following the established patterns in the repository:
GeneralUpdate.Drivelution
GeneralUpdate.Extension
Both packages:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.