Skip to content

Add NuGet package metadata to Drivelution and Extension components#153

Merged
JusterZhu merged 4 commits intomasterfrom
copilot/update-nuget-metadata
Feb 12, 2026
Merged

Add NuGet package metadata to Drivelution and Extension components#153
JusterZhu merged 4 commits intomasterfrom
copilot/update-nuget-metadata

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

NuGet Metadata Authoring for GeneralUpdate.Drivelution and GeneralUpdate.Extension

  • Analyze existing NuGet metadata patterns in other projects (GeneralUpdate.Core, GeneralUpdate.Common, GeneralUpdate.ClientCore)
  • Add comprehensive NuGet metadata to GeneralUpdate.Drivelution.csproj
  • Add comprehensive NuGet metadata to GeneralUpdate.Extension.csproj
  • Add ApplicationIcon property and icon files to both projects
  • Update version to 10.2.1 to match current release
  • Verify the project files build successfully with the new metadata
  • Verify NuGet packages can be created successfully
  • Request code review
  • Run security scan with CodeQL

Summary

Successfully added complete NuGet package metadata to both GeneralUpdate.Drivelution and GeneralUpdate.Extension components following the established patterns in the repository:

GeneralUpdate.Drivelution

  • Version: 10.2.1
  • Description: Cross-platform driver update management system
  • Tags: driver, update, upgrade, backup, validation, cross-platform, linux, windows, macos
  • Features: Driver backup, validation, version comparison, automatic rollback for Windows/Linux/macOS
  • Icons: ApplicationIcon and PackageIcon both configured

GeneralUpdate.Extension

  • Version: 10.2.1
  • Description: VS Code-inspired extension system for .NET applications
  • Tags: extension, plugin, update, download, rollback, compatibility, dependency, management
  • Features: Extension catalog management, download queue, version compatibility, dependency resolution, rollback support
  • Icons: ApplicationIcon and PackageIcon both configured

Both packages:

  • Use version 10.2.1 (matching the v10.2.1 tag)
  • Include proper copyright, authors, and company information
  • Reference both GeneralUpdate.ico (ApplicationIcon) and GeneralUpdate.png (PackageIcon)
  • Include repository URL and license information
  • Build and pack successfully without errors
Original prompt

This section details on the original issue you should resolve

<issue_title>NuGet Package Metadata Authoring</issue_title>
<issue_description>Fill in the NuGet metadata separately for the GeneralUpdate.Drivelution and GeneralUpdate.Extension components.</issue_description>

<agent_instructions>充分理解issue和代码上下文</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@JusterZhu
Copy link
Collaborator

@copilot You need to add the following content to the project file to give the NuGet package an icon.

  <ItemGroup>
    <None Include="../../../imgs/GeneralUpdate.ico">
      <Pack>True</Pack>
      <Link>%(Filename)%(Extension)</Link>
      <PackagePath>./</PackagePath>
    </None>
    <None Include="../../../imgs/GeneralUpdate.png">
      <Pack>True</Pack>
      <Link>%(Filename)%(Extension)</Link>
      <PackagePath>./</PackagePath>
    </None>
  </ItemGroup>

Copilot AI changed the title [WIP] Fill in NuGet package metadata for components Add NuGet package metadata to Drivelution and Extension components Feb 12, 2026
Copilot AI requested a review from JusterZhu February 12, 2026 11:33
@JusterZhu
Copy link
Collaborator

@copilot 9.5.10The version number needs to be modified to 10.2.1.

Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot You need to add the following content to the project file to give the NuGet package an icon.

...

Added ApplicationIcon property and included both GeneralUpdate.ico and GeneralUpdate.png files in both projects, matching the pattern used in GeneralUpdate.Core and GeneralUpdate.ClientCore. Changes verified in commit e96746f.

Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot 9.5.10The version number needs to be modified to 10.2.1.

Updated version to 10.2.1 in both GeneralUpdate.Drivelution and GeneralUpdate.Extension projects. Changes verified in commit ae7c8f2.

@JusterZhu JusterZhu marked this pull request as ready for review February 12, 2026 11:39
Copilot AI review requested due to automatic review settings February 12, 2026 11:39
Copilot AI requested a review from JusterZhu February 12, 2026 11:39
@JusterZhu JusterZhu merged commit ef203ab into master Feb 12, 2026
2 checks passed
@JusterZhu JusterZhu deleted the copilot/update-nuget-metadata branch February 12, 2026 11:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds NuGet packaging metadata (versioning, authorship, URLs, tags, icons) for the GeneralUpdate.Drivelution and GeneralUpdate.Extension components so they can be built and packed as first-class NuGet packages consistent with the rest of the repository.

Changes:

  • Added NuGet package metadata (Version 10.2.1, tags, release notes, repository metadata, icon settings) to GeneralUpdate.Drivelution.csproj and GeneralUpdate.Extension.csproj.
  • Added ApplicationIcon/PackageIcon configuration and included icon assets for both projects.
  • Ensured package icon files are included in the produced .nupkg via Pack=True items.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/c#/GeneralUpdate.Extension/GeneralUpdate.Extension.csproj Adds NuGet metadata + icon packing items for the Extension package.
src/c#/GeneralUpdate.Drivelution/GeneralUpdate.Drivelution.csproj Adds NuGet metadata + icon packing items for the Drivelution package.
src/c#/GeneralUpdate.Extension/GeneralUpdate.ico Adds project icon asset for Extension.
src/c#/GeneralUpdate.Drivelution/GeneralUpdate.ico Adds project icon asset for Drivelution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<Description>A VS Code-inspired extension system for .NET applications with comprehensive extension management, update, download, installation, rollback, and compatibility checking capabilities. Supports multi-platform extension deployment with dependency resolution.</Description>
<Copyright>Copyright © 2020-2026 JusterZhu. All rights reserved.</Copyright>
<PackageProjectUrl>https://github.com/GeneralLibrary/GeneralUpdate</PackageProjectUrl>
<PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackageLicenseUrl has been deprecated by NuGet for a while and typically produces pack warnings. Consider switching to PackageLicenseExpression (e.g., Apache-2.0) and/or PackageLicenseFile (packing the repo LICENSE) so the package has modern license metadata.

Suggested change
<PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>

Copilot uses AI. Check for mistakes.
<ApplicationIcon>GeneralUpdate.ico</ApplicationIcon>
<PackageIcon>GeneralUpdate.png</PackageIcon>
<RepositoryUrl>https://github.com/GeneralLibrary/GeneralUpdate</RepositoryUrl>
<RepositoryType>public</RepositoryType>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RepositoryType is expected to be the VCS type (commonly git). Using public is non-standard NuGet metadata and may be ignored by clients; consider changing it to git to ensure correct repository metadata in the nupkg.

Suggested change
<RepositoryType>public</RepositoryType>
<RepositoryType>git</RepositoryType>

Copilot uses AI. Check for mistakes.
<Description>A cross-platform driver update management system with support for Windows, Linux, and macOS. Provides driver backup, validation, version comparison, and automatic rollback capabilities.</Description>
<Copyright>Copyright © 2020-2026 JusterZhu. All rights reserved.</Copyright>
<PackageProjectUrl>https://github.com/GeneralLibrary/GeneralUpdate</PackageProjectUrl>
<PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackageLicenseUrl has been deprecated by NuGet for a while and typically produces pack warnings. Consider switching to PackageLicenseExpression (e.g., Apache-2.0) and/or PackageLicenseFile (packing the repo LICENSE) so the package has modern license metadata.

Suggested change
<PackageLicenseUrl>https://github.com/GeneralLibrary/GeneralUpdate?tab=Apache-2.0-1-ov-file#readme</PackageLicenseUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>

Copilot uses AI. Check for mistakes.
<ApplicationIcon>GeneralUpdate.ico</ApplicationIcon>
<PackageIcon>GeneralUpdate.png</PackageIcon>
<RepositoryUrl>https://github.com/GeneralLibrary/GeneralUpdate</RepositoryUrl>
<RepositoryType>public</RepositoryType>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RepositoryType is expected to be the VCS type (commonly git). Using public is non-standard NuGet metadata and may be ignored by clients; consider changing it to git to ensure correct repository metadata in the nupkg.

Suggested change
<RepositoryType>public</RepositoryType>
<RepositoryType>git</RepositoryType>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NuGet Package Metadata Authoring

3 participants