Geometry converter no longer writes. It was causing a reference loop#147
Merged
xfischer merged 2 commits intoGeoJSON-Net:masterfrom Jun 5, 2020
zeus82:master
Merged
Geometry converter no longer writes. It was causing a reference loop#147xfischer merged 2 commits intoGeoJSON-Net:masterfrom zeus82:master
xfischer merged 2 commits intoGeoJSON-Net:masterfrom
zeus82:master
Conversation
Member
|
Hi @zeus82, thanks for reporting this. This went out of the Tests radar. Can you provide an example for the code that's causing the exception, in order to add it to the tests project ? |
xfischer
requested changes
Jun 5, 2020
Contributor
Author
I have added a unit test that shows the problem. |
xfischer
approved these changes
Jun 5, 2020
Member
|
It's all OK. Great job @zeus82 ! Thank you. Will release a new NuGet right away |
xfischer
added a commit
that referenced
this pull request
Jun 5, 2020
GH-147 Co-Authored-By: Sanjeev M <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serializing Geometry using this converter resulted in:
This PR fixes that.