Skip to content

Add resourcehandlerinfo creation management command#14118

Merged
mattiagiupponi merged 5 commits intomasterfrom
resource_handlerinfo_fix
Apr 13, 2026
Merged

Add resourcehandlerinfo creation management command#14118
mattiagiupponi merged 5 commits intomasterfrom
resource_handlerinfo_fix

Conversation

@mattiagiupponi
Copy link
Copy Markdown
Contributor

@mattiagiupponi mattiagiupponi commented Apr 9, 2026

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi requested a review from giohappy April 9, 2026 10:14
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 9, 2026
@mattiagiupponi mattiagiupponi linked an issue Apr 9, 2026 that may be closed by this pull request
ResourceHandlerInfo is not always managed #14119
Closed
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Django management command, fixup_resourcehandlerinfo.py, designed to generate missing ResourceHandlerInfo for Dataset objects based on their subtype. It also updates the 0046_dataset_migration.py to incorporate similar logic for datasets that lack associated files. The review identifies a critical issue in both the new command and the migration: the handler_module_path is incorrectly set using the string representation of a handler instance rather than its proper class module path, which could lead to incorrect behavior. Furthermore, the logging configuration in the new management command is noted as an area for improvement, as it directly modifies the root logger, potentially causing conflicts with Django's default logging setup.

Comment thread geonode/upload/management/commands/fixup_resourcehandlerinfo.py Outdated
Comment thread geonode/upload/migrations/0046_dataset_migration.py Outdated
Comment thread geonode/upload/management/commands/fixup_resourcehandlerinfo.py Outdated
giohappy
giohappy reviewed Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiagiupponi I wouldn't add a dedicated management command to the core, since this isn't a functionality we need outside the one-shot usage of fixing the broken migration.
I would have it as a GIST maybe, or documented inside the wiki.

@mattiagiupponi
Copy link
Copy Markdown
Contributor Author

mattiagiupponi commented Apr 13, 2026

@giohappy PR updated

@mattiagiupponi mattiagiupponi merged commit 2deaccd into master Apr 13, 2026
14 of 15 checks passed
@mattiagiupponi mattiagiupponi deleted the resource_handlerinfo_fix branch April 13, 2026 15:01
github-actions Bot pushed a commit that referenced this pull request Apr 13, 2026
@mattiagiupponi @github-actions
Add resourcehandlerinfo creation management command (#14118)
c8840f6 
* Add resourcehandlerinfo creation management command

(cherry picked from commit 2deaccd)
@github-actions github-actions Bot mentioned this pull request Apr 13, 2026
Merged
mattiagiupponi added a commit that referenced this pull request Apr 13, 2026
@github-actions @mattiagiupponi
Add resourcehandlerinfo creation management command (#14118) (#14135)
8e6bc5a 
* Add resourcehandlerinfo creation management command

(cherry picked from commit 2deaccd)

Co-authored-by: mattiagiupponi <[email protected]>
dsuren1 added a commit to dsuren1/geonode that referenced this pull request Apr 15, 2026
@dsuren1
Merge commit 'f8e9fb4585129ad4e028ede61e55e468575207c2' into default_…
f6d5d23 
…format

* commit 'f8e9fb4585129ad4e028ede61e55e468575207c2': (34 commits)
  Fix formatting
  Merge commit from fork
  [Fixes GeoNode#13939] Add support for non-spatial datasets in CSV format in GeoNode (GeoNode#13900)
  build(deps): bump cryptography from 46.0.5 to 46.0.7 (GeoNode#14116)
  Add resourcehandlerinfo creation management command (GeoNode#14118)
  build(deps): update jwcrypto requirement from >=1.5.6 to >=1.5.7 (GeoNode#14127)
  build(deps-dev): update pip requirement from >=19.1 to >=26.0.1 (GeoNode#14125)
  [Fixes GeoNode#14095] Upload thumbnails through the UI for the remote spatial datasets (GeoNode#14096)
  build(deps): bump python-calamine from 0.6.1 to 0.6.2 (GeoNode#14102)
  build(deps): bump django from 5.2.12 to 5.2.13 (GeoNode#14115)
  [Fixes GeoNode#14111] Fix Harvester lookup failure caused by trailing ? during the remote resource upload through the API (GeoNode#14112)
  updated folder for RTD
  [Fixes GeoNode#14097] Label thesaurus is not reloaded on thesaurus changes (GeoNode#14098)
  [Fixes GeoNode#14109] Fixes Dataset creation from JSON Schema fails for LineString (GeoNode#14110)
  Renamed docs folder
  [Fixes GeoNode#14035] Implementation of a common ResourceManager base class for all resource types (GeoNode#14053)
  moving the example in the end of this section
  adding docs for the social account group sync
  [Fixes GeoNode#14042] deprecate overwrite_existing_layers in favor of action… (GeoNode#14043)
  [Fixes GeoNode#13936] Support for XLSX File Uploads in GeoNode (GeoNode#13937)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giohappy giohappy giohappy approved these changes

@sijandh35 sijandh35 Awaiting requested review from sijandh35

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@giohappy giohappy

Labels

backport 5.0.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ResourceHandlerInfo is not always managed

3 participants

@mattiagiupponi @giohappy @sijandh35