Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I finished the three functions per request
and tested, but commented all my tests
What did you learn from the changes you have made?
I learned how to read file in Python, also learned about Numpy array
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I would like to know how to use readline() instead of redlines() in Q1, should I use the size function in the for loop?
also, I am thinking do I need to create an empty array for summary_values in Q2 to avoid some errors?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
N/A
How were these changes tested?
I tested all 12 files, but still thinking if there is any null value, can my functions past the tests?
A reference to a related issue in your repository (if applicable)
Checklist