Conversation
HippocampusGirl
left a comment
There was a problem hiding this comment.
Thank you for this very important work! I have commented some of my ideas so that we don’t run into the same problems as last time.
| # echo "***Running TUI tests***" | ||
| # py.test /home/runner/actions-runner/_work/HALFpipe/HALFpipe/tests/tui | ||
| echo "***Running TUI tests***" | ||
| py.test --forked /home/runner/actions-runner/_work/HALFpipe/HALFpipe/tests/tui |
There was a problem hiding this comment.
I think it would be important to run all tests in the same pytest command, because only that way correct code coverage is generated. Is there any way you could annotate only the TUI tests to be forked?
There was a problem hiding this comment.
this is a long lasting issue with the tests, if they are not running completely separately there is some interaction, it might be something with the main thread being persistent all the time, even setting fixtures with @function do not help, for now the only reliable way is either to forked this or to put all tests in a list and then run a bash loop executing essentially these tests one by one
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
this branch also contains some new features, like now the directory trees inside the tui use the binding path, so that users do not see everything anymore in the tree |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 58.27% 58.27%
=======================================
Files 257 257
Lines 17278 17278
Branches 2744 2744
=======================================
Hits 10068 10068
Misses 6464 6464
Partials 746 746 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 5bc5fdb. # Conflicts: # tests/tui/test_spec_file_load.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
i made the changes that you suggested, it should be now stable but we will now know only if we start to using these tests with CI |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
No description provided.