Support selecting ica-aroma seed through base setting#929
Support selecting ica-aroma seed through base setting#929
Conversation
…actory to a lookup
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
- Coverage 57.11% 57.07% -0.05%
==========================================
Files 256 256
Lines 17264 17252 -12
Branches 2744 2742 -2
==========================================
- Hits 9860 9846 -14
- Misses 6671 6672 +1
- Partials 733 734 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ica_aroma = fields.Bool( | ||
| allow_none=True, | ||
| ) | ||
| aroma_melodic_seed = fields.Int( |
There was a problem hiding this comment.
I am wondering if this should be a global_setting rather than a per-feature thing. What do you think?
There was a problem hiding this comment.
Yes I was doubting this too during implementation. The way i understand it is that we basically want one of our testsettings to have the set seed and the rest to not, which is why I ended up deciding to go for a base setting implementation to be able to flexibly modify this. How could we control that with a global setting?
No description provided.