PR to resolve Issue #133#134
Merged
gustavodemorais merged 8 commits intoHTTP-APIs:developfrom Feb 5, 2020
Merged
Conversation
Sync master
* Adding python-socketio to requirements * Sending correct parameter to GraphOperations * Adding Socket to Agent and Defining sync Rules * Adjusting Docstrings * Adjusting tests to Mock Socket Connect * Typo and Coding Standards * Removing unused import and leftover comment * Restart Agent when it's too outdated * Adding Docstrings * Better naming and PEP8 * Receiving updates through socket packages * Connecting to hydrus * Updating Test Doc with changes from Hydra Core * Changing socket URL to use hydrus URL by default * Modifying empty modification table check to status code * Migrating from HTTP Table-Diff to Socket packages * Changing connection/reconnecting method using socket data * Adjusting Redis Graph Docker Hub Image * Dealing with warning use cases * Adjusting Agent's gitignore * Adjusting Agent's Graph Initialization routine That way the function can also be used to provide the ApiDoc to the GUI * Formatting embedded resources link and adjusting tests
* Adding python-socketio to requirements * Sending correct parameter to GraphOperations * Adding Socket to Agent and Defining sync Rules * Adjusting Docstrings * Adjusting tests to Mock Socket Connect * Typo and Coding Standards * Removing unused import and leftover comment * Restart Agent when it's too outdated * Adding Docstrings * Better naming and PEP8 * Receiving updates through socket packages * Connecting to hydrus * Updating Test Doc with changes from Hydra Core * Changing socket URL to use hydrus URL by default * Modifying empty modification table check to status code * Migrating from HTTP Table-Diff to Socket packages * Changing connection/reconnecting method using socket data * Adjusting Redis Graph Docker Hub Image * Dealing with warning use cases * Adjusting Agent's gitignore * Adjusting Agent's Graph Initialization routine That way the function can also be used to provide the ApiDoc to the GUI * Formatting embedded resources link and adjusting tests * Documentation major update (HTTP-APIs#128) * Adding small summary * Updating installation instructions * Updating description * Changing order, writing, layout and Porting details to internal README * Adjusting redis_setup comments writing
Organization has moved from gitter to slack.
gustavodemorais
approved these changes
Feb 2, 2020
.github/CONTRIBUTING.md
Outdated
| * Read this [how-to about writing a PR](https://github.com/blog/1943-how-to-write-the-perfect-pull-request) and this [other how-to about writing a issue](https://wiredcraft.com/blog/how-we-write-our-github-issues/) | ||
|
|
||
| * **first ask in chat**: if you find a problem, first ask for [help in the chat](https://gitter.im/HTTP-APIs/Lobby), then consider opening a issue. | ||
| * **first ask in chat**: if you find a problem, first ask for [help in the chat](https://hydraecosystem.slack.com/), then consider opening a issue. |
Contributor
There was a problem hiding this comment.
A good addition here would be: first ask in chat and search previous issues
Contributor
Author
There was a problem hiding this comment.
@Guttz, if you want then I can change that in my branch pratham-dev and have them in this PR.
Contributor
There was a problem hiding this comment.
Yup, that's what I would recommend. It's not exactly related to the PR but I would appreciate if you did so (: Thx
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Checklist
Description
This PR resolves Issue #133
Change logs
Due to upgradation of pip we were getting error while python3 setup.py install as pip.req changed to pip._internal.req and the way we import the dependencies from the requirements.txt has changed. This PR resolves this issue.