Skip to content

FIX: Automate the process of discovering the apiDocumentation#136

Merged
xadahiya merged 2 commits intoHTTP-APIs:developfrom
sameshl:automate_vocab
Feb 20, 2020
Merged

FIX: Automate the process of discovering the apiDocumentation#136
xadahiya merged 2 commits intoHTTP-APIs:developfrom
sameshl:automate_vocab

Conversation

@sameshl
Copy link
Copy Markdown
Member

@sameshl sameshl commented Feb 9, 2020

fixes #102
fixes HTTP-APIs/hydrus#428

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

Made the agent use the vocab in the context of the apiDoc
instead of just appending vocab at the end of the api url.

Change logs

Made the agent use the `vocab` in the context of the apiDoc
instead of just appending `vocab` at the end of the api url.

fixes HTTP-APIs#102
fixes HTTP-APIs/hydrus#428
Copy link
Copy Markdown
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sameshl
Copy link
Copy Markdown
Member Author

sameshl commented Feb 20, 2020

@xadahiya Is this PR supposed to auto merge on apporval? I see that you have apporved it but it has not merged yet.

@xadahiya xadahiya merged commit 2382044 into HTTP-APIs:develop Feb 20, 2020
@sameshl sameshl deleted the automate_vocab branch February 20, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants