Corrected logger format. Improved URL processing#90
Merged
Mec-iS merged 3 commits intoHTTP-APIs:developfrom Mar 6, 2019
shravandoda:url_check
Merged
Corrected logger format. Improved URL processing#90Mec-iS merged 3 commits intoHTTP-APIs:developfrom shravandoda:url_check
Mec-iS merged 3 commits intoHTTP-APIs:developfrom
shravandoda:url_check
Conversation
Fixes the issue when the user enters an extra trailing slash and the client requests to api_url//vocab instead of api_url/vocab
Added a context manager to the load_data method
Changed logger.info to logger.error. Corrected string formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #76 and #74.
Changes ->
Added a check for trailing slash in url input (Error when correct url or query is entered #74)
Included a context-manager for urllib request
Corrected the logger format (Logger format is incorrect #76)