Conversation
New approach preallocates nodes on page load for better performance than deleting and recreating from the template whenever the list is updated.
illegalprime
requested changes
Apr 10, 2017
Member
illegalprime
left a comment
There was a problem hiding this comment.
Looks good overall, a few nit picky things I think you should change.
| "@types/express": "^4.0.34", | ||
| "@types/handlebars": "^4.0.32", | ||
| "@types/mocha": "^2.2.38", | ||
| "@types/moment": "^2.13.0", |
Member
There was a problem hiding this comment.
This should be removed:
npm WARN deprecated @types/[email protected]: This is a stub types definition for Moment (https://github.com/moment/moment). Moment provides its own type definitions, so you don't need @types/moment installed!
| }, | ||
| "dependencies": { | ||
| "body-parser": "^1.17.1", | ||
| "cheerio": "^0.22.0", |
Member
There was a problem hiding this comment.
cheerio is still required in some places:
$ git grep cheerio
test/api.ts:import * as cheerio from "cheerio";
test/api.ts: let $ = cheerio.load(response.text);
Member
Author
There was a problem hiding this comment.
Thanks for catching this!
| "devDependencies": { | ||
| "@types/body-parser": "0.0.33", | ||
| "@types/chai": "^3.4.34", | ||
| "@types/cheerio": "^0.17.31", |
Member
There was a problem hiding this comment.
If cheerio is still needed, this is obviously still needed, just a reminder comment.
Member
Author
|
@illegalprime Thanks for letting me know about those. I amended the changes in fb68378 |
illegalprime
approved these changes
Apr 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8