This repository was archived by the owner on May 14, 2024. It is now read-only.
Move promises forward, OOP last; GitHub assignment used for all homework#5
Merged
mkruijt merged 8 commits intoHackYourFuture:masterfrom Mar 21, 2018
remarcmij:master
Merged
Move promises forward, OOP last; GitHub assignment used for all homework#5mkruijt merged 8 commits intoHackYourFuture:masterfrom remarcmij:master
mkruijt merged 8 commits intoHackYourFuture:masterfrom
remarcmij:master
Conversation
Contributor
|
I like the new homework assignments 👍 |
mkruijt
approved these changes
Mar 21, 2018
Member
mkruijt
left a comment
There was a problem hiding this comment.
Not sure about the "in class code" I know we have that in other repositories as well, but since the module is not taught by the same teacher every time and the possibility that they won't use the same code for the next class is quite big. It could be seen as confusing. But let's leave it there for now, we can always remove it later. Thank you for the update. let's reevaluate the order with callbacks/promises and OOP after this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from changing the order of promises and OOP, the major change is in the homework (MAKEMEs):
Week 1: Build a GitHub SPA using XMLHttpRequests and callbacks
Week 2: Convert the callbacks in the GitHub app to promises.
Week 3: Refactor the GibHub app to use ES6 classes for Repository, Contributor and View.