Open
Conversation
dwz92
suggested changes
Sep 7, 2024
dwz92
left a comment
There was a problem hiding this comment.
Your Part 1 is wrong but your part 2 is right. Please change your part 1 so that it passes the following tests:
anagram_checker("Slient", "listen") # True
anagram_checker("Slient", "Night") # False
anagram_checker("night", "Thing") # True
dwz92
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
In this pull request, I am adding functionality to an existing anagram_checker function. Specifically, I am implementing two main features:
What did you learn from the changes you have made?
I have learned that incorporating case sensitivity into an anagram checker can be achieved by adjusting the string normalization process based on a parameter. This change allows the function to be more flexible and adaptable to different use cases. The approach to solving the problem involves basic string manipulation techniques, including converting to lowercase, sorting, and comparing.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Initially, I considered using a different method to check for anagrams that involved counting character frequencies rather than sorting. While counting characters is efficient in some cases, sorting provides a straightforward and effective solution for this problem and ensures that the solution remains easy to understand and implement.