allow objects in json postMessage data#481
Merged
rbri merged 1 commit intoHtmlUnit:masterfrom Apr 28, 2022
Merged
Conversation
Member
|
Great will have a look |
Member
|
Looks good, many thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Right now if you're running
postMessage({myProperty: 1}, '*');the payload of the postMessage will actually be[object Object](a String with this value).What I did
I extracted the postMessage tests to another class since "Window2Test" already had enough tests and already counted up (Windows3Test also exists :))
Changing the payload in the
Window.postMessagemethod actually did the trick.I'm not 100% sure if Object is correct or if this needs to be specified down to something else though :-)
Potential improvements
I think we could rewrite the postMessage tests in general a bit ... didn't have time for that yet :-)