Add config to stop defaulting null datetime filter args to current time#1065
Closed
Add config to stop defaulting null datetime filter args to current time#1065
Conversation
This was referenced May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1064 by adding a JinjavaConfig value to turn off defaulting to the current date when a datetime filter is passed a null argument.
Instead it uses a fixed date, 2024-06-01, a potential deprecation date. I wanted a specific date so it was obvious that it was a default and not something like 0 which could be caused by other issues.
I'm going to find a way to make this date more configurable.