Skip to content

render back unresolved tokens#1072

Closed
marius-diumia wants to merge 3 commits intoHubSpot:masterfrom
marius-diumia:render-back-unknown-tokens
Closed

render back unresolved tokens#1072
marius-diumia wants to merge 3 commits intoHubSpot:masterfrom
marius-diumia:render-back-unknown-tokens

Conversation

@marius-diumia
Copy link
Copy Markdown

@marius-diumia marius-diumia commented May 20, 2023

This change allow to render back tokens which are unresolved.

Default behaviour is:

  • context key = "resolved"
  • template this is {{ key }} but this is {{ missing }}
  • with output this is resolved but this is

Enabling configuration .withRenderBackUnknownTokens(true) the behaviour is:

  • context key = "resolved"
  • template this is {{ key }} but this is {{ missing }}
  • with output this is resolved but this is {{ missing }}

@marius-diumia marius-diumia mentioned this pull request May 20, 2023
Open
@marius-diumia
Copy link
Copy Markdown
Author

marius-diumia commented Oct 10, 2023

Hi @jasmith-hs I want to ask you if there is a change to merge my PR in one of the next releases.
Currently I'm using the workaround as you suggested in the issue #1046. But it doesn't cover all the use cases which I need. Problem with this is that it doesn't support filters. I need to be able to maintain the variable not resolved, but in the same time to be able to assign a default. Just updated the unit test which show that use case.
Thanks

@jasmith-hs
Copy link
Copy Markdown
Contributor

jasmith-hs commented Oct 23, 2023

@marius-diumia would you be able change this to use the new Features way of adding flags: #1066, and then I can merge it in for the next release

@abarrafo abarrafo mentioned this pull request Jan 19, 2024
Merged
@abarrafo
Copy link
Copy Markdown
Contributor

abarrafo commented Jan 19, 2024

Just opened this pr #1150 leveraging Features..

@abarrafo
Copy link
Copy Markdown
Contributor

abarrafo commented Jan 22, 2024

@marius-diumia you can close this out now. Have a look in the test in PR: #1150 for usage. @jasmith-hs what is your release lifecycle? When would we expect this to be in maven-central? Thanks!

@marius-diumia
Copy link
Copy Markdown
Author

marius-diumia commented Jan 22, 2024

resolved by PR #1150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marius-diumia @jasmith-hs @abarrafo