Make restricted methods and properties to be configurable in JinjavaConfig#1076
Merged
manheychiu merged 6 commits intomasterfrom May 25, 2023
Merged
Make restricted methods and properties to be configurable in JinjavaConfig#1076manheychiu merged 6 commits intomasterfrom
JinjavaConfig#1076manheychiu merged 6 commits intomasterfrom
Conversation
jasmith-hs
reviewed
May 24, 2023
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
2c318fe to
012183b
Compare
jasmith-hs
approved these changes
May 24, 2023
Contributor
jasmith-hs
left a comment
There was a problem hiding this comment.
LGTM after the last point about immutability is addressed
hs-lsong
reviewed
May 24, 2023
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
hs-lsong
reviewed
May 24, 2023
src/main/java/com/hubspot/jinjava/el/ext/JinjavaBeanELResolver.java
Outdated
Show resolved
Hide resolved
hs-lsong
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
JinjavaBeanELResolver, restrict methods and properties based on the values fromJinjavaConfig(restrictedMethods,restrictedPropertiesanddeferredExecutionRestrictedMethods.