Defer BreakTag and ContinueTag if they're used in deferredExecutionMode#1222
Merged
jasmith-hs merged 1 commit intomasterfrom Dec 6, 2024
Merged
Defer BreakTag and ContinueTag if they're used in deferredExecutionMode#1222jasmith-hs merged 1 commit intomasterfrom
jasmith-hs merged 1 commit intomasterfrom
Conversation
Eventually we can handle them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are running a for loop and cannot evaluate whether it will be "broken" or "continued", we'll need special logic to handle that and make sure that the for-loop is reconstructed properly and that the deferred execution mode is propagated to the for-loop.
For now, we can simply defer these nodes, which will make this change compatible with eager execution insofar as deferred nodes signify that something isn't supported.
Eventually, we can handle them, but I don't want to block getting this jinja feature out waiting on that.