Merged
Conversation
added 2 commits
March 11, 2019 13:23
This allows the scopes being requested by the quickstart app to be defined in an environment variable called SCOPES. Scopes can be comma, space, or url-encoded space (%20) separated. Examples: SCOPES='contacts,hubdb' SCOPES='contacts hubdb' SCOPES='contacts%20hubdb'
|
nit: the URL param to kick off the authorization flow is Otherwise LGTM |
Contributor
Author
|
Good catch - all the other env vars match up to query parameters, so I think that makes sense |
885ec90 to
124166b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was suggested in #1, this allows the scopes being requested by the quickstart app to be defined in an environment variable called
SCOPES. Scopes can be separated by a comma, space, or url-encoded space (%20). Examples:SCOPES='contacts,hubdb'SCOPES='contacts hubdb'SCOPES='contacts%20hubdb'Also updates the docs to describe the scopes environment variable