Conversation
johnboiles
reviewed
Jun 27, 2023
| return samples # return list of samples, handle those lists in PPK2 API wrapper | ||
| # return list of samples and raw digital outputs | ||
| # handle those lists in PPK2 API wrapper | ||
| return samples, raw_digital_output |
There was a problem hiding this comment.
FYI this is a breaking change for any code that uses get_samples.
Collaborator
There was a problem hiding this comment.
The example was updated to show that :) Update your code with get_samples, _ = ppk2.get_samples(data)
There was a problem hiding this comment.
Yeah it all made sense once I found this PR! I had a tester rig break on the update from 0.9.1 and 0.9.2. I'll pin the exact version next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements digital channels to the PPK2 API.
On each sampling interval raw digital channel data is returned.
This data must then be converted in the user application. For that purpose a
digital_channelsmethod has been implemented. The method returns a 2D matrix, where the rows represent each digital channel. The row contains 1s and 0s, representing the HIGH and LOW state of that particular digital channel.Both examples have been updated to include the digital channel data.