Merged
Conversation
Contributor
|
So sorry I missed this. Yes indeed undo redo probably cannot be tested generically across everything. The reason |
Contributor
Author
|
@Moult No problem that gave me the time to reflect on the changes. Thanks for the explanations ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding feature scenarios for pset and property templates.
In summary :
{ifc}.by_type('IfcSimplePropertyTemplate')[0].id()but that wasn't it.I also added an if statement before purging the file to prevent info message saying there is no object to purge cluttering console if the default file contains no object.