Fix and test importing style attributes twice#1784
Merged
Moult merged 2 commits intoIfcOpenShell:v0.7.0from Oct 8, 2021
Merged
Fix and test importing style attributes twice#1784Moult merged 2 commits intoIfcOpenShell:v0.7.0from
Moult merged 2 commits intoIfcOpenShell:v0.7.0from
Conversation
Gorgious56
referenced
this pull request
Oct 8, 2021
Contributor
|
Yep all good. In general the tests only need to test what they're interested in, so you can delete all the asserts except for the len asserts - since the other asserts are covered in other tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a PR since I'm not totally sure if what I did makes sense, but the bug seems to be fixed and the test doesn't complain anymore so... :)