Skip to content

Minor fixes to BlenderBIM's IFC importer#2129

Closed
yorikvanhavre wants to merge 1 commit intoIfcOpenShell:v0.7.0from
yorikvanhavre:blenderbim-freecad-fix1
Closed

Minor fixes to BlenderBIM's IFC importer#2129
yorikvanhavre wants to merge 1 commit intoIfcOpenShell:v0.7.0from
yorikvanhavre:blenderbim-freecad-fix1

Conversation

@yorikvanhavre
Copy link
Copy Markdown
Contributor

  • Allow IfcAnnotations which have no related IfcGroup
  • Added a couple of IfcAnnotation.ObjectType types exported by FreeCAD

* Allow IfcAnnotations which have no related IfcGroup
* Added a couple of IfcAnnotation.ObjectType types exported by FreeCAD
@yorikvanhavre yorikvanhavre requested a review from Moult April 7, 2022 12:04
@Moult
Copy link
Copy Markdown
Contributor

Moult commented Apr 8, 2022

            if group: # annotations could exist that are not in an IfcGroup

Is this change hunk required? I don't see the purpose of it. Have you got a file to test where it is needed?

The place_object_in_spatial_decomposition_collection function decides where to place an object in the Blender collection tree. If it's an annotation in a drawing, then I place it in a particular Blender collection. Otherwise, it follows the rules of all other IFC elements (e.g. follows the spatial hierarchy or whatever).

@yorikvanhavre
Copy link
Copy Markdown
Contributor Author

yorikvanhavre commented Apr 8, 2022

This file doesn't open with the current code: https://gitlab.com/openingdesign/101_W_33rd_St/-/blob/main/Models%20and%20CAD/IFC/101_W_33rd_St_Details_D.ifc it fails because the "group" list is empty. but yeah, i might not have got the correct cause

@theoryshaw
Copy link
Copy Markdown
Member

Moult added a commit that referenced this pull request Apr 9, 2022
@Moult
Copy link
Copy Markdown
Contributor

Moult commented Apr 9, 2022

I tested with the file and it works without that hunk. Are you sure that file demonstrates an issue?

@Moult
Copy link
Copy Markdown
Contributor

Moult commented Apr 11, 2022

Bump @yorikvanhavre :)

@yorikvanhavre
Copy link
Copy Markdown
Contributor Author

Indeed everything seems working now... weird! Anyway, the best bugs are the bugs that fix themselves :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants