Merged
Conversation
Closed
7 tasks
e2c363d to
8832a33
Compare
8832a33 to
0d6bdbe
Compare
Contributor
Author
|
|
0d6bdbe to
3ecfd67
Compare
YdrMaster
suggested changes
Jan 30, 2024
| UNREACHABLE(); | ||
| } | ||
|
|
||
| if (broadcaster.needBroadcast()) { |
Contributor
There was a problem hiding this comment.
这里没必要判断吧，cpu 走不走坐标计算对性能的影响微乎其微
| {dt} const *const addr[{inputsNum}]; | ||
| }}; | ||
|
|
||
| __device__ __forceinline__ static {dt} fn({dt} a, {dt} b) {{ |
Contributor
There was a problem hiding this comment.
判断大小用大于号小于号和三目运算符不用转型。直接内联进去就填一个大于号小于号就行了
fca3a9c to
86a8f34
Compare
Contributor
|
没改啊，没推上来？ |
86a8f34 to
e237349
Compare
Contributor
Author
现在改了 |
YdrMaster
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.