feat/refactor_network_mixed_secure_insecure_channels by aarmoa · Pull Request #319 · InjectiveLabs/sdk-python

aarmoa · 2024-04-18T18:56:31Z

Refactoring in Network class to support mixed secure and insecure endpoints.
Marked the Network parameter use_secure_connection as deprecated.

Summary by CodeRabbit

New Features
- Introduced new parameters for specifying different gRPC channel credentials.
Refactor
- Deprecated use_secure_connection and credentials parameters in favor of more flexible connection handling.
Tests
- Added tests to ensure deprecation warnings are correctly triggered for outdated parameters.
Chores
- Issued deprecation warnings for legacy parameters to guide users towards new implementations.

…ure endpoints

coderabbitai · 2024-04-18T18:57:06Z

Walkthrough

The changes involve deprecating the use_secure_connection parameter in the Network class and introducing new parameters for specifying grpc_channel_credentials. Tests have been added to check for deprecation warnings related to these changes in both the Network and AsyncClient classes.

Changes

File Path	Change Summary
`pyinjective/core/network.py`	Deprecated `use_secure_connection`, introduced new parameters for `grpc_channel_credentials`, added methods for channel creation.
`tests/core/test_network_deprecation_warnings.py` `tests/test_async_client_deprecation_warnings.py`	Added tests for deprecation warnings related to parameters in `Network` and `AsyncClient`.

🐇🌟🐇
Code changes dance, in lines they prance,
Old gives way, to the new's advance.
Tests now guard, warnings in stance,
A rabbit's touch, in every code's expanse.
🐇🌟🐇

Recent Review Details

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 7b4e0b2 and c47c94e.

Files selected for processing (1)

tests/test_async_client_deprecation_warnings.py (3 hunks)

Files skipped from review as they are similar to previous changes (1)

tests/test_async_client_deprecation_warnings.py

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)

tests/test_async_client_deprecation_warnings.py (1)

Line range hint 583-583: Duplicate method name test_stream_keepalive_deprecation_warning found. This could lead to one of the methods being overshadowed and not tested. Please rename one of the methods to ensure both are uniquely identifiable and executable.

coderabbitai

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)

tests/test_async_client_deprecation_warnings.py (1)

Line range hint 583-583: Duplicate method definition for test_stream_keepalive_deprecation_warning. Consider removing or renaming one of the definitions to ensure all tests are executed as expected.

(feat) Refactoring in Network class to support mixed secure and insec…

d916599

…ure endpoints

aarmoa requested a review from nicolasbaum April 18, 2024 18:56

nicolasbaum approved these changes Apr 18, 2024

View reviewed changes

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

abel added 2 commits April 18, 2024 17:18

(fix) Solve pre-commit issues

7b4e0b2

(fix) Renamed a deprecation test

c47c94e

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

aarmoa merged commit b43fc0a into master Apr 19, 2024

aarmoa deleted the feat/refactor_network_mixed_secure_insecure_channels branch April 19, 2024 14:26

aarmoa mentioned this pull request Apr 19, 2024

Feat/network refactoring from master to dev #320

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/refactor_network_mixed_secure_insecure_channels#319

feat/refactor_network_mixed_secure_insecure_channels#319
aarmoa merged 3 commits intomasterfrom
feat/refactor_network_mixed_secure_insecure_channels

aarmoa commented Apr 18, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 18, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aarmoa commented Apr 18, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aarmoa commented Apr 18, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 18, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)