Skip to content

Feat/add order data creation without order mask#339

Merged
aarmoa merged 2 commits intodevfrom
feat/add_order_data_creation_without_order_mask
Jul 30, 2024
Merged

Feat/add order data creation without order mask#339
aarmoa merged 2 commits intodevfrom
feat/add_order_data_creation_without_order_mask

Conversation

@aarmoa
Copy link
Copy Markdown
Collaborator

@aarmoa aarmoa commented Jul 30, 2024 •
edited by coderabbitai bot
Loading

  • Added the method in Composer, to allow order cancellation just using the order's identifiers

Summary by CodeRabbit

  • New Features
    • Introduced a method to create order data without requiring a specific order mask, enhancing flexibility in order data generation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 30, 2024 •
edited
Loading

Walkthrough

The recent update introduces a new method, order_data_without_mask, to the Composer class within the pyinjective/composer.py file. This method allows for the creation of OrderData instances with a fixed order mask, enhancing flexibility in order data generation. By providing optional parameters for order_hash and cid, it supports varied use cases while simplifying the order creation process.

Changes

Files Change Summary
pyinjective/composer.py Added order_data_without_mask method to Composer class for flexible order data creation.

Poem

Hop along, with joy we see,
A method fresh, as new as spring,
With orders made so easily,
A fixed mask, what joy it brings!
🐇✨ Let's celebrate the code's delight,
In rabbit hops, we find our light!

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 716a628 and ab3371e.

Files selected for processing (1)
  • pyinjective/composer.py (1 hunks)
Additional comments not posted (1)
pyinjective/composer.py (1)

214-227: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to order_data_without_mask are correctly implemented.

@aarmoa aarmoa merged commit ea5c929 into dev Jul 30, 2024
@aarmoa aarmoa deleted the feat/add_order_data_creation_without_order_mask branch July 30, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aarmoa