Merged
Conversation
thewtex
reviewed
Nov 21, 2025
CMakeLists.txt
Outdated
| ExternalProject_add(oneTBB | ||
| URL https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2022.2.0.tar.gz | ||
| URL_HASH SHA256=f0f78001c8c8edb4bddc3d4c5ee7428d56ae313254158ad1eec49eced57f6a5b | ||
| URL https://github.com/oneapi-src/oneTBB/archive/refs/tags/v2022.3.0.tar.gz |
Member
Author
There was a problem hiding this comment.
On mac and Linux yes. I dont have a working windows box yes. I'll remove this for now.
| from packaging.version import Version | ||
|
|
||
| # Version needs to be python PEP 440 compliant (no leading v) | ||
| VERSION = '6.0b1'.removeprefix("v") |
Member
Author
There was a problem hiding this comment.
Not yet. But stripping 'v' is needed to get the same backward compatible behavior when using version tags for checking out and setting version. The v needs to be stripped somewhere.
cae8241 to
6c029b9
Compare
dzenanz
reviewed
Nov 21, 2025
Fail early if the version is incompatible with PEP 440.
6c029b9 to
a91178f
Compare
thewtex
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.