Open
Conversation
added 12 commits
August 12, 2015 22:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bonjour,
Afin de préparer mon entrevue avec Augustin MONSAINGEON, je suis passé à travers ce code .
J'ai eu un peu de mal à le comprendre donc je l'ai refactoré selon ma compréhension pour avoir de plus petites classes avec chacune sa responsabilité.
Étant donné que je ne connais pas toutes les subtilités de cette application, il se peut que j'ai introduit des bugs, donc ce pul request n'est pas à utiliser tel-quel.
J'aurais aimé pouvoir ajouter des tests unitaires mais le temps m'a manqué.
Pour résumé, cette branche représente beaucoup la façon dont je code et ce à quoi vous pourrez vous attendre si je rentre dans votre équipe.