This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Revert "Changing csv_reader_py impl to return df from objmode"#932
Merged
Hardcode84 merged 1 commit intorelease_0.36.0from Sep 30, 2020
Merged
Conversation
This reverts commit 811e9f0.
|
Hello @Hardcode84! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
PokhodenkoSA
approved these changes
Sep 30, 2020
Contributor
kozlov-alexey
left a comment
There was a problem hiding this comment.
@PokhodenkoSA Why revert is needed and why not just skip affected tests and create a JIRA issue?
Has the problem with tests been seen locally or just in particular env?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #918
Due to unstable tests on Windows