Merged
Conversation
OisinRobinson
approved these changes
Feb 15, 2024
Collaborator
OisinRobinson
left a comment
There was a problem hiding this comment.
I think that looks ok. I cannot see anything glaring that will cause issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through profiling it was confirmed that the way unions were implemented (by broadcasting changes through
_pt_updated) was very inefficient. This PR moves to backing all Packtype objects with aBitVectorobject that handles the data storage and bit extraction/alteration.In simulations a 10x speedup was achieved from these changes.
This work also introduces a
Base._pt_enable_profiling()method that prints out a report of the number of objects created at the end of the run, this can be helpful when debugging performance issues.