Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change structs and unions are now lazily expanded as fields are accessed - this leads to a considerable speedup when using deeply nested data structures.
Previously, all fields at all levels within a data structure would be expanded when an instance was created or unpacked from a value - however in many use cases only a small fraction of the fields would be accessed. As Packtype objects operate over a shared "bit vector" (with sub-objects referring to windows into this shared bit vector), it is not necessary to expand all fields in order to preserve the state. As such, fields may be lazily expanded as and when they are required by a testbench or other consumer.
In some internal testing, this has reduced Packtype's execution time under profiling from ~60% down to less than 10%.