adding the anagram functions and completed assignment-1#1
Open
adding the anagram functions and completed assignment-1#1
Conversation
…any further computation is made
juliagallucci
suggested changes
Aug 27, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
You are on the right track. Your code is checking if each letter in word_a is in word_b, but you’re not removing matched letters!
This means repeated letters can cause false positives. For example: "aabb", "abbb" would return True, but it should be False. Please revise
juliagallucci
approved these changes
Aug 28, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Good. Your functions work correctly. One note for improvement would be for simplicity and readability, you can use Python’s built-in sorted() function to compare the characters of both words instead of manually looping and replacing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
I have prior programming knowledge so this was easy to complete
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist