src/Makefile.global.in (1)

392-394: Fix typo in marker comment (IvoryrSQL → IvorySQL).

Minor but worth correcting for consistency/searchability.

-#IvoryrSQL:END - SQL oracle_test
+#IvorySQL:END - SQL oracle_test

src/oracle_test/perl/PostgreSQL/Test/Cluster.pm (2)

1591-1604: Accept a more ergonomic parameter name for oraport.

Supporting oraport => alongside 'ivorysql.port' improves call-site ergonomics and avoids dotted hash keys.

-	# Select a oraport.
-	my $oraport;
-	if (defined $params{'ivorysql.port'})
-	{
-		$oraport = $params{'ivorysql.port'};
-	}
-	else
-	{
-		# When selecting a port, we look for an unassigned TCP port number,
-		# even if we intend to use only Unix-domain sockets.  This is clearly
-		# necessary on $use_tcp (Windows) configurations, and it seems like a
-		# good idea on Unixen as well.
-		$oraport = get_free_port();
-	}
+	# Select an IvorySQL port (oraport).
+	my $oraport_param = defined $params{oraport} ? $params{oraport} : $params{'ivorysql.port'};
+	my $oraport = defined $oraport_param ? $oraport_param : get_free_port();

---

2361-2380: Optional: allow background_psql to target oraport.

For parity with psql/safe_psql, accept connect_to_oraport.

 sub background_psql
 {
 	my ($self, $dbname, %params) = @_;
@@
-	else
-	{
-		$psql_connstr = $self->connstr($dbname);
-	}
+	else
+	{
+		$psql_connstr = $self->connstr($dbname, $params{connect_to_oraport} ? 1 : 0);
+	}

src/bin/pg_dump/t/oracle/001_pg_dump_ora_specific.pl (1)

163-167: Drop unused variables.

$connect_to_oraport (declared) and $encoding (assigned but unused) add noise and an extra query.

-my ($connect_to_oraport);
-
-# ICU doesn't work with some encodings
-my $encoding = $node->safe_psql('postgres', 'show server_encoding', connect_to_oraport => 1);
+# (optional) If needed later, detect server encoding via connect_to_oraport.
+# my $encoding = $node->safe_psql('postgres', 'show server_encoding', connect_to_oraport => 1);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: syasirs
PR: IvorySQL/IvorySQL#858
File: src/Makefile.global.in:513-514
Timestamp: 2025-09-02T10:43:25.242Z
Learning: In IvorySQL Makefile.global.in, $(wildcard t/oracle/*.pl) is used instead of t/oracle/*.pl in Oracle TAP test discovery because the t/oracle directory is optional and may not exist in most builds. The wildcard function safely returns empty string when the directory is missing, preventing shell expansion errors.

src/bin/pg_dump/t/oracle/001_pg_dump_ora_specific.pl (2)

134-136: Harden regex: escape dot and allow flexible whitespace

Make the match resilient across formatting changes.

-       regexp       => qr/^CREATE EDITIONABLE PACKAGE public.test_pkg AUTHID DEFINER  AS/m,
+       regexp       => qr/^CREATE\s+EDITIONABLE\s+PACKAGE\s+public\.test_pkg\s+AUTHID\s+DEFINER\s+AS\b/m,

---

147-149: Harden regex for PACKAGE BODY

Same robustness tweak as above.

-       regexp       => qr/^CREATE PACKAGE BODY public.test_pkg  AS/m,
+       regexp       => qr/^CREATE\s+PACKAGE\s+BODY\s+public\.test_pkg\s+AS\b/m,

src/bin/pg_dump/t/oracle/001_pg_dump_ora_specific.pl (3)

151-154: Tighten DROP regex (escape dot, tolerate spaces)

Prevents false negatives due to spacing differences.

-       regexp => qr/^DROP PACKAGE IF EXISTS public.test_pkg;/m,
+       regexp => qr/^DROP\s+PACKAGE\s+IF\s+EXISTS\s+public\.test_pkg;/m,

---

164-169: Remove unused variables

$connect_to_oraport and $encoding are unused; keep the connect check without binding to a variable.

-my ($connect_to_oraport);
-
-# ICU doesn't work with some encodings
-my $encoding = $node->safe_psql('postgres', 'show server_encoding', connect_to_oraport => 1);
+# Exercise oraport connectivity
+$node->safe_psql('postgres', 'show server_encoding', connect_to_oraport => 1);

---

57-77: Optional: Add an owner-aware run to cover pkgowner fix

Since the PR mentions reading package owner from pkgowner, consider a third run without --no-owner and assert the emitted ALTER PACKAGE ... OWNER TO ... (or equivalent) to prevent regressions.

I can draft the additional run and assertion if you want.

Also applies to: 120-156

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.