Conversation
WalkthroughAdds a CodeRabbit config, introduces a new phony make target Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant Make as Make/GNUmakefile.in
participant Script as tools/enable-git-hooks.sh
Dev->>Make: run `make code-format`
Note right of Make #dff0d8: new phony target added
Make->>Script: exec `bash tools/enable-git-hooks.sh`
Script-->>Make: installs/enables hooks (sync)
Make-->>Dev: return status
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.coderabbit.yaml(1 hunks)GNUmakefile.in(1 hunks)Makefile(0 hunks)README.md(1 hunks)README_CN.md(1 hunks)contrib/ivorysql_ora/src/datatype/oradate.c(4 hunks)contrib/ivorysql_ora/src/datatype/oratimestamp.c(25 hunks)contrib/ivorysql_ora/src/datatype/oratimestampltz.c(6 hunks)contrib/ivorysql_ora/src/datatype/oratimestamptz.c(7 hunks)contrib/ivorysql_ora/src/guc/guc.c(2 hunks)src/backend/utils/misc/guc_tables.c(7 hunks)src/backend/utils/misc/ivy_guc.c(15 hunks)
💤 Files with no reviewable changes (1)
- Makefile
🧰 Additional context used
🧬 Code graph analysis (5)
contrib/ivorysql_ora/src/datatype/oratimestamptz.c (5)
src/backend/utils/adt/timestamp.c (1)
timestamptz_in(417-481)src/include/postgres.h (4)
CStringGetDatum(354-358)ObjectIdGetDatum(256-260)Int32GetDatum(216-220)PointerGetDatum(326-330)src/backend/utils/adt/formatting.c (1)
timestamptz_to_char(4667-4712)src/include/utils/timestamp.h (1)
TimestampTzGetDatum(51-55)src/backend/utils/adt/varlena.c (1)
cstring_to_text(193-197)
contrib/ivorysql_ora/src/datatype/oradate.c (4)
src/backend/utils/adt/date.c (2)
date_timestamp(1347-1356)date_in(113-179)src/include/postgres.h (2)
CStringGetDatum(354-358)PointerGetDatum(326-330)src/include/utils/timestamp.h (1)
TimestampGetDatum(45-49)src/backend/utils/adt/varlena.c (1)
cstring_to_text(193-197)
contrib/ivorysql_ora/src/datatype/oratimestamp.c (4)
src/backend/utils/adt/timestamp.c (1)
timestamp_in(165-228)src/include/postgres.h (4)
CStringGetDatum(354-358)ObjectIdGetDatum(256-260)Int32GetDatum(216-220)PointerGetDatum(326-330)src/include/utils/timestamp.h (2)
TimestampGetDatum(45-49)IntervalPGetDatum(57-61)src/backend/utils/adt/varlena.c (1)
cstring_to_text(193-197)
contrib/ivorysql_ora/src/datatype/oratimestampltz.c (5)
src/backend/utils/error/elog.c (2)
errmsg(1070-1086)errcode(853-864)src/backend/utils/adt/formatting.c (1)
timestamptz_to_char(4667-4712)src/include/utils/timestamp.h (1)
TimestampTzGetDatum(51-55)src/include/postgres.h (1)
PointerGetDatum(326-330)src/backend/utils/adt/varlena.c (1)
cstring_to_text(193-197)
src/backend/utils/misc/ivy_guc.c (1)
src/backend/utils/error/elog.c (3)
errcode(853-864)errmsg(1070-1086)errhint(1317-1332)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: oracle_regression (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: meson_build (ubuntu-latest)
- GitHub Check: oracle_pg_regression (ubuntu-latest)
- GitHub Check: contrib_regression
- GitHub Check: pg_regression (ubuntu-latest)
🔇 Additional comments (16)
contrib/ivorysql_ora/src/datatype/oradate.c (1)
1-746: LGTM! Formatting changes only.The changes in this file are purely cosmetic whitespace and alignment adjustments. No functional changes detected.
README.md (1)
35-35: LGTM! Documentation accurately reflects the new workflow.The update from
make enable-git-hookstomake code-formatcorrectly documents the new build target introduced in GNUmakefile.in while preserving the alternative command path.contrib/ivorysql_ora/src/datatype/oratimestamp.c (1)
1-1705: LGTM! Formatting changes only.All changes are cosmetic whitespace and alignment adjustments with no functional impact.
GNUmakefile.in (1)
161-167: LGTM! Build target properly implemented.The new
code-formattarget is correctly integrated:
- Depends on
submake-generated-headers(appropriate for formatting tools that need generated headers)- Properly declared in
.PHONY- Aligns with the documentation updates in README.md and README_CN.md
README_CN.md (1)
21-21: LGTM! Chinese documentation matches English version.The Chinese README correctly documents the new
make code-formatworkflow, maintaining consistency with README.md.contrib/ivorysql_ora/src/datatype/oratimestamptz.c (1)
1-757: LGTM! Formatting changes only.All changes are cosmetic whitespace and alignment adjustments with no functional impact.
.coderabbit.yaml (1)
1-10: LGTM! Minimal and appropriate CodeRabbit configuration.The configuration is well-structured:
- Schema validation enabled for editor support
chillprofile appropriate for less strict reviews- Auto-review enabled for the specified base branches (
masterandIVORY_REL_5_STABLE)- Drafts excluded from auto-review (line 9), which is a good practice
contrib/ivorysql_ora/src/guc/guc.c (1)
39-43: LGTM! Dead code removal.The removal of the disabled NLS length semantics GUC code is appropriate:
- The code was already wrapped in
#if 0blocks (disabled)- Removes unused internal scaffolding (
nls_length_semantics_optionsarray andnls_length_semanticsglobal)IvorysqlOraDefineGucsis now an empty function, which is valid for future GUC additionscontrib/ivorysql_ora/src/datatype/oratimestampltz.c (2)
200-212: LGTM!The formatting changes to variable declarations improve code readability and are consistent with the codebase style.
239-245: LGTM!Function call formatting is cleaner and more readable.
src/backend/utils/misc/ivy_guc.c (3)
33-54: LGTM!Variable declaration formatting is consistent and improves code readability.
449-493: LGTM!The formatting changes to these check functions improve readability while preserving all logic and error handling.
103-103: LGTM!All formatting changes throughout the file are consistent with the pg_bsd_indent refactoring objective and improve code layout without altering functionality.
Also applies to: 240-240, 288-310
src/backend/utils/misc/guc_tables.c (3)
2154-2156: LGTM!The formatting of IVY_GUC macro include blocks is consistent and properly paired. The blank lines improve code readability.
Also applies to: 3892-3894, 4177-4179, 4990-4992, 5450-5452
579-579: LGTM!Variable declaration formatting is consistent with surrounding code.
5134-5135: LGTM!Comment formatting change improves consistency.
|
@coderabbitai generate docstrings |
✅ Actions performedInitiated docstring generation; will generate only if new commits exist. |
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @OreoYang. * #918 (comment) The following files were modified: * `contrib/ivorysql_ora/src/datatype/oradate.c` * `contrib/ivorysql_ora/src/datatype/oratimestamp.c` * `contrib/ivorysql_ora/src/datatype/oratimestampltz.c` * `contrib/ivorysql_ora/src/datatype/oratimestamptz.c` * `contrib/ivorysql_ora/src/guc/guc.c` * `src/backend/utils/misc/ivy_guc.c`
| int last_day = 0; | ||
| Timestamp result; | ||
|
|
||
| int y = 0, |
There was a problem hiding this comment.
The formatted result looks worse than before. How do you think?
There was a problem hiding this comment.
This part is auto generated by tools/pg_bsd_indent, which is following pg code style,
|
No comments, proceed. |
Summary by CodeRabbit
Chores
Documentation
Style