Skip to content

IVORY_REL_5_STABLE: enhance github CI to not ignore warning#997

Closed
OreoYang wants to merge 2 commits intoIvorySQL:IVORY_REL_5_STABLEfrom
OreoYang:IVORY_REL_5_STABLE
Closed

IVORY_REL_5_STABLE: enhance github CI to not ignore warning#997
OreoYang wants to merge 2 commits intoIvorySQL:IVORY_REL_5_STABLEfrom
OreoYang:IVORY_REL_5_STABLE

Conversation

@OreoYang
Copy link
Copy Markdown
Collaborator

@OreoYang OreoYang commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

Release Notes

  • Chores

    • Enhanced build system with stricter compiler checks to catch potential issues during compilation.

  • Documentation

    • Updated installation guide links to v5.0 across all documentation.
    • Updated Chinese documentation links to v5.0 versions.
    • Added information about pre-commit hook formatting workflow.

✏️ Tip: You can customize this high-level summary in your review settings.

@OreoYang OreoYang mentioned this pull request Dec 3, 2025
Open
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

This PR updates the build configuration to enforce stricter compiler warnings and updates documentation links across both English and Chinese README files from version 4.5 to 5.0, including notes on developer formatting and CI workflows.

Changes

Cohort / File(s) Change Summary
Build Configuration
.github/workflows/build.yml		 Added -Werror -Wshadow compiler flags to the compile step, treating warnings as errors and enabling shadow variable checks.
Documentation
README.md, README_CN.md		 Updated installation and documentation links from v4.5 to v5.0 across all installation methods (Yum, Docker, RPM, source code); added notes on developer formatting hooks and Cirrus FormatCheck workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that the new compiler flags (-Werror -Wshadow) don't cause existing build failures or unintended side effects.
  • Confirm all documentation links are correctly updated to v5.0 endpoints.
  • Check consistency of formatting notes added to README and README_CN.

Possibly related issues

Possibly related PRs

Suggested reviewers

  • NotHimmel

Poem

🐰 Version five, we hop along,
With stricter checks to keep us strong—
No shadows lurk, no warnings hide,
Docs and configs align with pride! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: enhancing GitHub CI to not ignore compiler warnings, which aligns with the core modification of adding -Werror and -Wshadow flags to CFLAGS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 873c2f8 and 74ed8d3.

📒 Files selected for processing (3)
  • .github/workflows/build.yml (1 hunks)
  • README.md (1 hunks)
  • README_CN.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: pg_regression (ubuntu-latest)
  • GitHub Check: contrib_regression
  • GitHub Check: oracle_pg_regression (ubuntu-latest)
  • GitHub Check: oracle_regression (ubuntu-latest)
  • GitHub Check: meson_build (ubuntu-latest)
🔇 Additional comments (4)
README_CN.md (1)

30-30: Documentation links updated to v5.0.

Links have been consistently updated from v4.5 to v5.0 across all installation guidance sections, mirroring changes in README.md. The updates look accurate and maintain consistent formatting.

Also applies to: 32-36

README.md (2)

26-32: Documentation links updated to v5.0.

Installation links consistently updated from v4.5 to v5.0 across quick-start and all four installation methods (Yum, Docker, RPM, source code). Updates mirror README_CN.md for consistency across both language versions.

34-37: Developer formatting notes are clear and well-structured.

The new section clearly explains the pre-commit hook setup, dependency on in-tree tools (pgindent, pg_bsd_indent), and the Cirrus FormatCheck workflow. This aligns well with the stricter CI enforcement from .github/workflows/build.yml.

.github/workflows/build.yml (1)

38-38: The code snippet in this review comment does not match the actual codebase.

Line 38 of .github/workflows/build.yml currently reads run: make without the CFLAGS modifications shown in the review. The change adding -Werror -Wshadow flags has not been applied or is not present in the checked-out state.

Likely an incorrect or invalid review comment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OreoYang OreoYang closed this Dec 3, 2025
@OreoYang OreoYang deleted the IVORY_REL_5_STABLE branch December 9, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@OreoYang