Merged
Conversation
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
…ing file then listing
There was a problem hiding this comment.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ❌ | Missing directories: data/processed/server_logs, data/processed/user_logs, data/processed/event_logs |
| Part 1 - Q5 | ❌ | Missing files in data/processed/server_logs |
| Part 1 - Q6 | ❌ | Missing files in data/processed/user_logs; Missing files in data/processed/event_logs |
| Part 1 - Q7 | ❌ | One or more files with ipaddr in data/raw not removed. |
| Part 1 - Q8 | ❌ | data/inventory.txt does not exist |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
…nger switches directories
…into assignment Merge should be done now?
|
Please reopen this PR so Learning support can review changes. Follow the instructions given here https://github.com/UofT-DSI/onboarding/blob/main/onboarding_documents/submissions.md#handling-accidental-merges |
There was a problem hiding this comment.
Well done!
Just one comment:
- Try to avoid excessive use of
cdcommand in shell script. You can use relative path instead. It will make your script more readable and maintainable.
For e.g. for Question 8, instead of
cd ../..
touch inventory.txt
cd processed
echo $(ls user_logs server_logs event_logs) >> ../inventory.txt
you can do:
ls -R ./data/processed > ./data/inventory.txt
- For future PRs(Pull request), try to add PR comments. Your comments will help us understand what you learned and the challenges you faced.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist