Module 2 pull request by Sam Negassi#11
Closed
samNson wants to merge 3 commits intoJSCRIPT300-Spring2015:masterfrom
Closed
Module 2 pull request by Sam Negassi#11samNson wants to merge 3 commits intoJSCRIPT300-Spring2015:masterfrom
samNson wants to merge 3 commits intoJSCRIPT300-Spring2015:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Unfortunately you can't do this in JavaScript yet. With ES6 you'll be able to set default arguments in this fashion, but for now, you need to just pass in arg and assign it a value inside the setDate: function (arg) {
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created the Module Pattern for the enhancedDate object. I had difficulty type testing when no argument is submitted when setDate() method is called. I tried
if (typeof arg === "undefined") { date = new Date } ;
to address that case but when i call the getDate() to see the result, i got NaN as output. So i scrapped that code and used a more forgiving one.