Skip to content

Added support for comment(s) for column definitions in CREATE TABLE s…#743

Merged
wumpz merged 4 commits intoJSQLParser:masterfrom
PraTrick:742
Feb 7, 2019
Merged

Added support for comment(s) for column definitions in CREATE TABLE s…#743
wumpz merged 4 commits intoJSQLParser:masterfrom
PraTrick:742

Conversation

@PraTrick
Copy link
Contributor

@PraTrick PraTrick commented Feb 5, 2019

Added support for comment(s) for column definitions in CREATE TABLE statements.

CREATE TABLE table_name (id bigint (20) NOT NULL AUTO_INCREMENT, another_column_id bigint (20) NOT NULL COMMENT 'column id as sent by SYSTEM', PRIMARY KEY (id), UNIQUE KEY uk_another_column_id (another_column_id))

This should fix 742

@coveralls
Copy link

coveralls commented Feb 5, 2019

Coverage Status

Coverage increased (+0.1%) to 83.074% when pulling 5b62a22 on PraTrick:742 into cb0e0b7 on JSQLParser:master.

@wumpz wumpz merged commit 07b8676 into JSQLParser:master Feb 7, 2019
PraTrick added a commit to PraTrick/JSqlParser that referenced this pull request Feb 16, 2019
* changed license header to represent the projects dual license

* changed license header to represent the projects dual license

* changed license header to represent the projects dual license

* changed license header to represent the projects dual license

* Added support for comment(s) for column definitions in CREATE TABLE s… (JSQLParser#743)

* Added support for comment(s) for column definitions in CREATE TABLE statements

* Added support for comment(s) for column definitions in CREATE TABLE statements #2

* To increase code coverage

* To increase code coverage #2

* Added support for 'ALTER TABLE CHANGE COLUMN' (JSQLParser#741)

* Added support for 'ALTER TABLE CHANGE COLUMN oldName newName columnDefinition'. Please see https://dev.mysql.com/doc/refman/8.0/en/alter-table.html for reference.

* Returned import ordering to avoid conflicts

* Improved the tests somewhat

Now also test the getOptionalSpecifier() for both cases (null and not-null)

* Expanded tests for ALTER TABLE ... CHANGE

* implemented optimize for, fixes JSQLParser#348

* implemented optimize for, fixes JSQLParser#348

* Support for simple informix outer joins. (JSQLParser#745)

* added support for simple informix outer joins
added some test code

* added support for simple informix outer joins
added some test code

* more testing for better code coverage

* added support for simple informix outer joins
added some test code

* more testing for better code coverage

* fixes JSQLParser#747

* fixes JSQLParser#733

* fixes JSQLParser#707

* Update README.md

* Update README.md
wumpz pushed a commit that referenced this pull request Feb 19, 2019
…752)

* Merge recent changes in the master from the master (#1)

* changed license header to represent the projects dual license

* changed license header to represent the projects dual license

* changed license header to represent the projects dual license

* changed license header to represent the projects dual license

* Added support for comment(s) for column definitions in CREATE TABLE s… (#743)

* Added support for comment(s) for column definitions in CREATE TABLE statements

* Added support for comment(s) for column definitions in CREATE TABLE statements #2

* To increase code coverage

* To increase code coverage #2

* Added support for 'ALTER TABLE CHANGE COLUMN' (#741)

* Added support for 'ALTER TABLE CHANGE COLUMN oldName newName columnDefinition'. Please see https://dev.mysql.com/doc/refman/8.0/en/alter-table.html for reference.

* Returned import ordering to avoid conflicts

* Improved the tests somewhat

Now also test the getOptionalSpecifier() for both cases (null and not-null)

* Expanded tests for ALTER TABLE ... CHANGE

* implemented optimize for, fixes #348

* implemented optimize for, fixes #348

* Support for simple informix outer joins. (#745)

* added support for simple informix outer joins
added some test code

* added support for simple informix outer joins
added some test code

* more testing for better code coverage

* added support for simple informix outer joins
added some test code

* more testing for better code coverage

* fixes #747

* fixes #733

* fixes #707

* Update README.md

* Update README.md

* Fix handles the following cases: 1) DROP INDEX 2) ADD UNIQUE INDEX 3) ALGORITHM 4) USING <index type>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot parse CREATE TABLE statement with COMMENT for column definitions

3 participants