Skip to content

fix(idp): allow CORS for all clients on token endpoint #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melvincarvalho wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
+17 −10
Open

fix(idp): allow CORS for all clients on token endpoint #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48614c5
fix(idp): allow CORS for all clients on token endpoint
melvincarvalho Dec 29, 2025
3f3d4e7
fix(cors): add DPoP to allowed headers for Solid-OIDC
melvincarvalho Dec 29, 2025
b496dc4
fix(idp): strip iss parameter from authorization redirects
melvincarvalho Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/idp/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,19 @@ export async function idpPlugin(fastify, options) {
const req = request.raw;
const res = reply.raw;

// Intercept setHeader to strip 'iss' parameter from Location redirects
// oidc-provider v9+ always includes 'iss' (RFC 9207) but Mashlib's auth doesn't handle it
const originalSetHeader = res.setHeader.bind(res);
res.setHeader = (name, value) => {
if (name.toLowerCase() === 'location' && typeof value === 'string' && value.includes('iss=')) {
// Strip the iss parameter from the redirect URL
const url = new URL(value, 'http://localhost');
url.searchParams.delete('iss');
value = url.pathname + url.search + url.hash;
}
return originalSetHeader(name, value);
};

// oidc-provider is now configured with /idp routes, no stripping needed
// Ensure parsed body is accessible to oidc-provider
// Fastify parses body into request.body, oidc-provider looks for req.body
Expand Down
12 changes: 3 additions & 9 deletions src/idp/provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,10 @@ export async function createProvider(issuer) {
// Clock tolerance for token validation
clockTolerance: 60, // 60 seconds

// Allow CORS for public clients from any origin
// Allow CORS for all clients from any origin
// This is needed for web apps like Mashlib loaded from CDN
clientBasedCORS: (ctx, origin, client) => {
// Allow all origins for public clients (no client_secret)
if (client.tokenEndpointAuthMethod === 'none') {
return true;
}
// For confidential clients, check registered origins
return false;
},
// Solid servers are public and should accept requests from any web app
clientBasedCORS: () => true,

// Render errors
renderError: async (ctx, out, error) => {
Expand Down
2 changes: 1 addition & 1 deletion src/ldp/headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export function getCorsHeaders(origin) {
return {
'Access-Control-Allow-Origin': origin || '*',
'Access-Control-Allow-Methods': 'GET, HEAD, POST, PUT, DELETE, PATCH, OPTIONS',
'Access-Control-Allow-Headers': 'Accept, Authorization, Content-Type, If-Match, If-None-Match, Link, Slug, Origin',
'Access-Control-Allow-Headers': 'Accept, Authorization, Content-Type, DPoP, If-Match, If-None-Match, Link, Slug, Origin',
'Access-Control-Expose-Headers': 'Accept-Patch, Accept-Post, Allow, Content-Type, ETag, Link, Location, Updates-Via, WAC-Allow',
'Access-Control-Allow-Credentials': 'true',
'Access-Control-Max-Age': '86400'
Expand Down