Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ You can find the current docs on our [website](https://docs.javawebstack.org/fra
<dependency>
<groupId>org.javawebstack</groupId>
<artifactId>validator</artifactId>
<version>1.0.1</version>
<version>1.0.2</version>
</dependency>
```
13 changes: 3 additions & 10 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<properties>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
<buildVersion>1.0.1-SNAPSHOT</buildVersion>
<buildVersion>1.0.2-SNAPSHOT</buildVersion>
</properties>

<groupId>org.javawebstack</groupId>
Expand Down Expand Up @@ -44,15 +44,8 @@
<dependency>
<groupId>org.javawebstack</groupId>
<artifactId>abstract-data</artifactId>
<version>1.0.4</version>
<version>1.0.6</version>
</dependency>
<!--- Temporary fix for transitive vulnerabilities -->
<dependency>
<groupId>org.yaml</groupId>
<artifactId>snakeyaml</artifactId>
<version>1.33</version>
</dependency>
<!--- ============================================ -->
<dependency>
<groupId>com.sun.mail</groupId>
<artifactId>javax.mail</artifactId>
Expand All @@ -61,7 +54,7 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>5.8.1</version>
<version>5.10.0</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
17 changes: 10 additions & 7 deletions src/main/java/org/javawebstack/validator/Validator.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

import org.javawebstack.abstractdata.AbstractArray;
import org.javawebstack.abstractdata.AbstractElement;
import org.javawebstack.abstractdata.AbstractMapper;
import org.javawebstack.abstractdata.AbstractNull;
import org.javawebstack.abstractdata.mapper.Mapper;
import org.javawebstack.abstractdata.mapper.MapperTypeSpec;
import org.javawebstack.validator.rule.*;

Expand Down Expand Up @@ -33,6 +33,7 @@ public class Validator {
registerRuleType("ipv6", IPv6AddressRule.Validator.class, IPv6AddressRule.class);
registerRuleType("int", IntegerRule.Validator.class, IntegerRule.class);
registerRuleType("integer", IntegerRule.Validator.class, IntegerRule.class);
registerRuleType("double", DoubleRule.Validator.class, DoubleRule.class);
registerRuleType("numeric", NumericRule.Validator.class, NumericRule.class);
registerRuleType("num", NumericRule.Validator.class, NumericRule.class);
registerRuleType("date", DateRule.Validator.class, DateRule.class);
Expand All @@ -44,8 +45,12 @@ public class Validator {
registerRuleType("email", EmailRule.Validator.class, EmailRule.class);
registerRuleType("regex", RegexRule.Validator.class, RegexRule.class);
registerRuleType("uuid", UUIDRule.Validator.class, UUIDRule.class);
registerRuleType("charset", CharsetRule.Validator.class, CharsetRule.class);
registerRuleType("word_count", WordCountRule.Validator.class, WordCountRule.class);
}

private final Map<String[], ValidationConfig> rules = new HashMap<>();

public static void registerRuleType(String name, Class<? extends ValidationRule> type, Class<? extends Annotation> annotationClass) {
if (!ruleAnnotationClasses.containsKey(type) && annotationClass != null)
ruleAnnotationClasses.put(type, annotationClass);
Expand Down Expand Up @@ -118,20 +123,18 @@ public static Validator getValidator(Class<?> type) {
return validator;
}

public static <T> T map(ValidationContext context, Class<T> type, AbstractElement element, AbstractMapper mapper) {
public static <T> T map(ValidationContext context, Class<T> type, AbstractElement element, Mapper mapper) {
Validator validator = getValidator(type);
ValidationResult result = validator.validate(context, element);
if (!result.isValid())
throw new ValidationException(result);
return mapper.fromAbstract(element, type);
return mapper.map(element, type);
}

public static <T> T map(ValidationContext context, Class<T> type, AbstractElement element) {
return map(context, type, element, new AbstractMapper());
return map(context, type, element, new Mapper());
}

private final Map<String[], ValidationConfig> rules = new HashMap<>();

public Validator rule(String[] key, ValidationRule... rules) {
return rule(key, Arrays.asList(rules));
}
Expand Down Expand Up @@ -321,7 +324,7 @@ private static Map<String[], ValidationConfig> getClassRules(Field field, Class<
return rules;
}
if (type.equals(Double.class) || type.equals(Float.class)) {
rules.put(new String[0], new ValidationConfig(field, Collections.singletonList(new NumericRule.Validator())));
rules.put(new String[0], new ValidationConfig(field, Collections.singletonList(new DoubleRule.Validator(Double.MIN_VALUE, Double.MAX_VALUE))));
return rules;
}
if (type.equals(UUID.class)) {
Expand Down
77 changes: 77 additions & 0 deletions src/main/java/org/javawebstack/validator/rule/CharsetRule.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
package org.javawebstack.validator.rule;

import org.javawebstack.abstractdata.AbstractElement;
import org.javawebstack.validator.ValidationContext;

import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
import java.lang.reflect.Field;
import java.util.Locale;

@Target(ElementType.FIELD)
@Retention(RetentionPolicy.RUNTIME)
public @interface CharsetRule {

String value() default "";
boolean upper() default false;
boolean lower() default false;
boolean numeric() default false;
boolean accents() default false;

class Validator implements ValidationRule {

private static final String ALPHA = "abcdefghijklmnopqrstuvwxyz";
private static final String ACCENTS = "äëïöüéàèùâêîôûç";

private final String charset;

public Validator(CharsetRule rule) {
this(makeCharset(rule));
}

public Validator(String charset) {
this.charset = charset;
}

public Validator(String[] params) {
this(params.length > 0 ? params[0] : "");
}

public String validate(ValidationContext context, Field field, AbstractElement value) {
if (value == null || value.isNull())
return null;
if (!value.isPrimitive())
return "Not a string value";
char[] chars = value.string().toCharArray();
for(int i=0; i<chars.length; i++) {
char c = chars[i];
if(!charset.contains(String.valueOf(c))) {
return String.format("Forbidden character '%c' at position %d", c, i);
}
}
return null;
}

private static String makeCharset(CharsetRule rule) {
StringBuilder sb = new StringBuilder(rule.value());
if(rule.lower()) {
sb.append(ALPHA);
if(rule.accents())
sb.append(ACCENTS);
}
if(rule.upper()) {
sb.append(ALPHA.toUpperCase(Locale.ROOT));
if(rule.accents())
sb.append(ACCENTS.toUpperCase(Locale.ROOT));
}
if(rule.numeric()) {
sb.append("1234567890");
}
return sb.toString();
}

}

}
74 changes: 74 additions & 0 deletions src/main/java/org/javawebstack/validator/rule/DoubleRule.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
package org.javawebstack.validator.rule;

import org.javawebstack.abstractdata.AbstractElement;
import org.javawebstack.validator.ValidationContext;

import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
import java.lang.reflect.Field;

@Target(ElementType.FIELD)
@Retention(RetentionPolicy.RUNTIME)
public @interface DoubleRule {

double min() default Double.MIN_VALUE;
double max() default Double.MAX_VALUE;

class Validator implements ValidationRule {

private final double min;
private final double max;

public Validator(DoubleRule rule) {
this(rule.min(), rule.max());
}

public Validator(double min, double max) {
this.min = min;
this.max = max;
}

public Validator(String[] params) {
double min = Double.MIN_VALUE;
double max = Double.MAX_VALUE;
if (params.length > 0)
min = Double.parseDouble(params[0]);
if (params.length > 1)
max = Double.parseDouble(params[1]);
this.min = min;
this.max = max;
}

public String validate(ValidationContext context, Field field, AbstractElement value) {
if (value == null || value.isNull())
return null;
double v;
if (value.isNumber()) {
v = value.number().doubleValue();
} else if (value.isString()) {
try {
v = Double.parseDouble(value.string());
} catch (NumberFormatException ex) {
return "Not a double value";
}
} else {
return "Not a double value";
}
if (v < min)
return String.format("Smaller than the minimum value (%f < %f)", v, min);
if (v > max)
return String.format("Greater than the maximum value (%f > %f)", v, max);
return null;
}

public String toString() {
return "Validator{" +
"min=" + min +
", max=" + max +
'}';
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
@Retention(RetentionPolicy.RUNTIME)
public @interface IntegerRule {
int min();
int max();
int max() default Integer.MAX_VALUE;
int step() default 1;

class Validator implements ValidationRule {
Expand Down
53 changes: 53 additions & 0 deletions src/main/java/org/javawebstack/validator/rule/WordCountRule.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package org.javawebstack.validator.rule;

import org.javawebstack.abstractdata.AbstractElement;
import org.javawebstack.validator.ValidationContext;

import java.lang.reflect.Field;

public @interface WordCountRule {

int value();
int max() default 1;
String separator() default " ";

class Validator implements ValidationRule {

private final int min;
private final int max;
private final String separator;

public Validator(WordCountRule rule) {
this(rule.value(), rule.max(), rule.separator());
}

public Validator(int min, int max, String separator) {
this.min = min;
this.max = Math.min(min, max);
this.separator = separator;
}

public Validator(String[] params) {
this(
params.length > 0 ? Integer.parseInt(params[0]) : 1,
params.length > 1 ? Integer.parseInt(params[0]) : 1,
params.length > 2 ? params[2] : " "
);
}

public String validate(ValidationContext context, Field field, AbstractElement value) {
if (value == null || value.isNull())
return null;
if (!value.isPrimitive())
return "Not a string value";
int wordCount = value.string().split(separator).length;
if (wordCount < min)
return String.format("Less than the minimum word count (%d < %d)", wordCount, min);
if (wordCount > max)
return String.format("More than maximum word count (%d > %d)", wordCount, max);
return null;
}

}

}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package test.org.javawebstack.validator;


import org.javawebstack.abstractdata.AbstractMapper;
import org.javawebstack.abstractdata.mapper.Mapper;
import org.javawebstack.validator.ValidationContext;
import org.javawebstack.validator.Validator;
import org.javawebstack.validator.rule.IntegerRule;
Expand All @@ -16,11 +16,11 @@ public class AnnotationTest {
public void testIntegerAnnotation () {
Validator validator = Validator.getValidator(TestObject1.class);
TestObject1 test = new TestObject1();
assertFalse(validator.validate(new ValidationContext(), new AbstractMapper().toAbstract(test)).isValid());
assertFalse(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
test.x = 6;
assertTrue(validator.validate(new ValidationContext(), new AbstractMapper().toAbstract(test)).isValid());
assertTrue(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
test.x = 1338;
assertFalse(validator.validate(new ValidationContext(), new AbstractMapper().toAbstract(test)).isValid());
assertFalse(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
}

private static class TestObject1 {
Expand Down
40 changes: 40 additions & 0 deletions src/test/java/test/org/javawebstack/validator/DoubleRuleTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
package test.org.javawebstack.validator;

import org.javawebstack.abstractdata.mapper.Mapper;
import org.javawebstack.validator.ValidationContext;
import org.javawebstack.validator.Validator;
import org.javawebstack.validator.rule.DoubleRule;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.*;

public class DoubleRuleTest {
@Test
public void testSimple() {
Validator validator = Validator.getValidator(SimpleTest.class);
SimpleTest test = new SimpleTest();
test.value = "hello world";
assertFalse(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
test.value = "13.37";
assertTrue(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
}

@Test
public void testEdgeCases() {
Validator validator = Validator.getValidator(EdgeTest.class);
EdgeTest test = new EdgeTest();
test.value = 9.9;
assertFalse(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
test.value = 10.1;
assertTrue(validator.validate(new ValidationContext(), new Mapper().map(test)).isValid());
}

private class SimpleTest {
@DoubleRule
String value;
}

private class EdgeTest {
@DoubleRule(min = 10)
Double value;
}
}
Loading