Open
Conversation
juliagallucci
suggested changes
May 5, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Revise. Output should be a boolean only
Owner
Author
Thank you for your feedback, I've already fixed the output. should I open a new PR? |
juliagallucci
approved these changes
May 5, 2025
juliagallucci
left a comment
There was a problem hiding this comment.
Great! One note for improvement, no need for 'if...else'—the comparison itself returns a boolean
Owner
Author
Done!, Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am adding the code for assignment 1 and homework
What did you learn from the changes you have made?
How to make a function to detect if two words are anagrams.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
We can add phrases instead of single words and the function has to look for anagrams inside 2 phrases
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I think there was no problem since the topics were discussed in class.
How were these changes tested?
I tested with the several cases provided in the notebook
A reference to a related issue in your repository (if applicable)
N/A
Checklist