Open
Conversation
DwardEE
approved these changes
Aug 13, 2025
DwardEE
left a comment
There was a problem hiding this comment.
Good work
The logic model looks beautiful and professional.
For the temp table, remember to separate the CREATE TABLE and INSERT with a semicolon, and match the exact five-column structure from the original vendor table. In the DATE section, your query structure is solid, but the April 2022 filter is currently set to 2023, adjust that year to match the requirement. Neither of these are main requirements of the assignment, so feel free to maek these optional changes, but the assignment is considered complete. Overall a solid submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding assignment 1 part 1 and 2
What did you learn from the changes you have made?
Leaned coding with sql
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I mostly followed class lectures ; still new to things
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Submitting assignment was a challenge - still struggling to understand
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist