Closed
Conversation
added sentence-transformers library to Dockerfile.tmpl
Contributor
|
Thanks @pjkm28. Could you add a unit test in https://github.com/Kaggle/docker-python/tree/main/tests ? |
Added a unit test in for sentence-transformers
Author
|
@Philmod I have now added the unit test case, kindly check it and tell me if there are any issues with it. |
Philmod
suggested changes
Jun 3, 2022
Contributor
Philmod
left a comment
There was a problem hiding this comment.
Thanks @pjkm28 , but the tests are failing: https://gist.github.com/Philmod/5a7230e8a12921f31c9dad559a74a6ec
Contributor
|
Hey @pjkm28 , would you mind fixing the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added sentence-transformers library to Dockerfile.tmpl