Conversation
|
currently main build is broken, will ptal to see if i can fix it. not too sure if qgrid is used for other packages, we'll need to see if it affect other things |
|
i think jim mentioned that using the pretest image which has this version did not seem to fix the widget issue, right? |
fixing main build. - kagglehub login changes required updating our tests - latest matplotlib is needed by handful of package, but breaks learntools. i provided a workaround
| model_handle = m.group(1) | ||
| path = m.group(2) | ||
| filepath = f"/input/tests/data/kagglehub/models/{model_handle}/{path}" | ||
| if not os.path.isfile(filepath): |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| f"and copy it to `./docker-python/tests/data/kagglehub/models/{model_handle}/{path}`.") | ||
| return | ||
|
|
||
| with open(filepath, "rb") as f: |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
| with open(filepath, "rb") as f: | ||
| self.send_response(200) | ||
| self.send_header("Content-type", "application/octet-stream") | ||
| self.send_header("Content-Length", os.path.getsize(filepath)) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
|
added a change to remove qgrid, checked the package usage, little to no usage. i will removed qgrid along with test, so that it doesn't block this upgrade |
I think this will break qgrid fwiw, unsure how often that is used.